Skip to content

ci: the WebKit interaction lane also runs for #8360's new click-guard paths - #9376

Merged
cixzhang merged 1 commit into
mainfrom
ci/webkit-scope-8360-paths
Nov 1, 2026
Merged

cixzhang merged 1 commit into
mainfrom
ci/webkit-scope-8360-paths

Conversation

@cixzhang

@cixzhang cixzhang commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Maintainer impact

Change

  • .github/workflows/ci.yml, pr-interaction-webkit scope paths: utils/(…|flatTree|inputStream|clickGuard|selectionLock|coarsePointer), privateAttributes/hapticSwitch.stylex.ts, hooks/(…|isRtlElement).
  • .github/scripts/ci-interaction-webkit.test.mjs: the "untouched" example utils/clickGuard.ts, now in scope, becomes utils/focusReturn.ts.
  • Both hunks are taken verbatim from fix(core): one click guard for the menu press model and the gesture host #8360, with credit to its author.

Evidence

Scope

  • One change: the WebKit proof's path scope.
  • Public text contains no internal Meta context.
… paths

Co-authored-by: vjeux <197597+vjeux@users.noreply.github.com>
@vercel

vercel Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Nov 1, 2026 6:15pm UTC

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 1, 2026
@astracat-bot

astracat-bot Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

AI review status for this pull request.

Review status Updated
🟢 Reviewed (for maintainers only) Nov 1, 2026, 6:15 PM UTC
@cixzhang
cixzhang marked this pull request as ready for review November 1, 2026 18:04
@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

PR Analysis Report

🔎 Preview · 8c94a7d

Storybook · Sandbox · built from this PR's head

Package size: no published package changed; no new dependencies.

Not run on this PR: add ci:run-visual, ci:run-a11y or ci:run-rtl to run them.

CI impact: +2.7 job-min per update · pool +3.4% · standard runners · 1 CI action or script file changed (not measured)
Before After Change
Job-minutes per PR update 78.7 81.3 +2.7
Runner pool, runner-minutes a day 36,690 37,932 +1,241 (+3.4%)
Average concurrent jobs 25.5 26.3 +0.9
Time to green (median → this run) — 11.9 min —
Runs a day 466 466 0

Changed jobs: pr-interaction-webkit changed: standard

Not measured (the jobs that use these keep their recent minutes above): .github/scripts/ci-interaction-webkit.test.mjs.

Assumptions: before is each job's average over the last 20 pull-request runs; after keeps that for unchanged jobs and uses this run's minutes for added or changed ones, weighted by how often each changed job ran in those runs; runs a day averages the seven whole days before today; time to green compares this run with the median of those runs that ran the same jobs.


Generated by PR Enrichment workflow | View full report

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ready to merge. The WebKit lane's scope adds seven paths and drops none, so no pull request loses the proof, and the routing tests pass. One optional follow-up: no test pins the new paths, because the #8360 replay still passes on GestureHost.ts alone. Adding them to the "runs for" list in ci-interaction-webkit.test.mjs would catch a later edit that drops one.

[Automated review]

'packages/core/src/Toast/Toast.tsx',
'packages/core/src/Selector/useSelectorPresentation.ts',
'packages/core/src/utils/clickGuard.ts',
'packages/core/src/utils/focusReturn.ts',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: the seven paths this PR adds to the scope aren't asserted anywhere. This file passes unchanged against the old regex, because the #8360 replay below already runs on GestureHost.ts. Adding packages/core/src/utils/clickGuard.ts, inputStream.ts, coarsePointer.ts, flatTree.ts, selectionLock.ts, packages/core/src/privateAttributes/hapticSwitch.stylex.ts and packages/core/src/hooks/isRtlElement.ts to the "runs for" list above would pin them.

This branch was successfully deployed

1 active deployment
Preview — 8c94a7db Deployed Nov 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

1 participant