feat(ishikawa): support empty gap branched with []#7891
Conversation
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: 46b3f83 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/layout-tidy-tree
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7891 +/- ##
============================================
- Coverage 77.79% 20.02% -57.78%
============================================
Files 409 184 -225
Lines 30328 10134 -20194
Branches 5175 1410 -3765
============================================
- Hits 23595 2029 -21566
- Misses 5410 8040 +2630
+ Partials 1323 65 -1258
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
sidharthv96
left a comment
There was a problem hiding this comment.
Thanks for the PR @sillydan1, The problem is clear, but I think we need to change our approach to the problem.
Is there anything stopping us from rendering properly by measuring the size of nodes and adjusting the spacing as required, instead of having to manually add empty spaces?
📑 Summary
This PR adds the possibility of specifying an "empty" branch in ishikawa diagrams. This is useful when you have long branch descriptions that would have the text collide with other branches.
Demonstration of the problem:
ishikawa Demo Category Very long branch description that is cool and more text goes here describing the potential cause Another long branch name that is less cool, but also describes another potential cause Category2 Very long branch description that is cool and more text goes here describing the potential cause Another long branch name that is less cool, but also describes another potential causeThis PR enables you to add extra spacing between the branches.
ishikawa Demo Category Very long branch description that is cool and more text goes here describing the potential cause [] [] Another long branch name that is less cool, but also describes another potential cause Category2 Very long branch description that is cool and more text goes here describing the potential cause [] [] Another long branch name that is less cool, but also describes another potential cause📏 Design Decisions
I'm unsure about the overall approach here - maybe the real solution is to calculate the bounding boxes of the labels better instead?
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.