Skip to content

fix: add null check in _delete_memory to prevent AttributeError #3860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
majiayu000 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add null check in _delete_memory to prevent AttributeError #3860

majiayu000 wants to merge 1 commit into from
+35 −1

Conversation

@majiayu000
Copy link

@majiayu000 majiayu000 commented Dec 27, 2025

Summary

  • Added null check for existing_memory before accessing .payload
  • Raises clear ValueError when memory_id does not exist
  • Fixed both sync and async versions of _delete_memory

Test plan

  • Added unit test for delete with non-existent memory_id
  • All existing memory tests pass

Fixes #3849
@majiayu000
fix: add null check in _delete_memory to prevent AttributeError
42e53e0 
- Added null check for existing_memory before accessing payload
- Raises clear ValueError when memory_id does not exist
- Fixed both sync and async versions of _delete_memory
- Added test to verify proper error handling

Fixes mem0ai#3849

Signed-off-by: majiayu000 <1835304752@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@majiayu000