Skip to content

Demix SVGFilterPrimitiveStandardAttributes to SVGFE*Element - #5188

Merged
Elchi3 merged 2 commits into
mdn:mainfrom
foolip:rm-SVGFilterPrimitiveStandardAttributes
May 26, 2021
Merged

Demix SVGFilterPrimitiveStandardAttributes to SVGFE*Element#5188
Elchi3 merged 2 commits into
mdn:mainfrom
foolip:rm-SVGFilterPrimitiveStandardAttributes

Conversation

@foolip

@foolip foolip commented May 21, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@foolip
foolip requested review from a team and chrisdavidmills and removed request for a team May 21, 2021 11:00
@github-actions

github-actions Bot commented May 21, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Web/API/SVGFECompositeElement
Title: SVGFECompositeElement
on GitHub
Flaw count: 9

  • macros:
    • /en-us/docs/web/api/svgfilterprimitivestandardattributes (url: /en-US/docs/Web/API/SVGFilterPrimitiveStandardAttributes) does not exist
    • /en-US/docs/Web/API/SVGFECompositeElement/height does not exist
    • /en-US/docs/Web/API/SVGFECompositeElement/in1 does not exist
    • /en-US/docs/Web/API/SVGFECompositeElement/result does not exist
    • /en-US/docs/Web/API/SVGFECompositeElement/type does not exist
    • and 4 more flaws omitted

URL: /en-US/docs/Web/API/SVGFETurbulenceElement
Title: SVGFETurbulenceElement
on GitHub
Flaw count: 12

  • macros:
    • /en-us/docs/web/api/svgfilterprimitivestandardattributes (url: /en-US/docs/Web/API/SVGFilterPrimitiveStandardAttributes) does not exist
    • /en-US/docs/Web/API/SVGFETurbulenceElement/baseFrequencyX does not exist
    • /en-US/docs/Web/API/SVGFETurbulenceElement/baseFrequencyY does not exist
    • /en-US/docs/Web/API/SVGFETurbulenceElement/height does not exist
    • /en-US/docs/Web/API/SVGFETurbulenceElement/numOctaves does not exist
    • and 7 more flaws omitted

URL: /en-US/docs/Web/API/SVGFEDiffuseLightingElement
Title: SVGFEDiffuseLightingElement
on GitHub
Flaw count: 11

  • macros:
    • /en-us/docs/web/api/svgfilterprimitivestandardattributes (url: /en-US/docs/Web/API/SVGFilterPrimitiveStandardAttributes) does not exist
    • /en-US/docs/Web/API/SVGFEDiffuseLightingElement/diffuseConstant does not exist
    • /en-US/docs/Web/API/SVGFEDiffuseLightingElement/height does not exist
    • /en-US/docs/Web/API/SVGFEDiffuseLightingElement/in1 does not exist
    • /en-US/docs/Web/API/SVGFEDiffuseLightingElement/kernelUnitLengthX does not exist
    • and 6 more flaws omitted

URL: /en-US/docs/Web/API/SVGFEGaussianBlurElement
Title: SVGFEGaussianBlurElement
on GitHub
Flaw count: 11

  • macros:
    • /en-us/docs/web/api/svgfilterprimitivestandardattributes (url: /en-US/docs/Web/API/SVGFilterPrimitiveStandardAttributes) does not exist
    • /en-US/docs/Web/API/SVGFEGaussianBlurElement/edgeMode does not exist
    • /en-US/docs/Web/API/SVGFEGaussianBlurElement/height does not exist
    • /en-US/docs/Web/API/SVGFEGaussianBlurElement/in1 does not exist
    • /en-US/docs/Web/API/SVGFEGaussianBlurElement/result does not exist
    • and 6 more flaws omitted

URL: /en-US/docs/Web/API/SVGFEColorMatrixElement
Title: SVGFEColorMatrixElement
on GitHub
Flaw count: 12

  • macros:
    • /en-us/docs/web/api/svgfilterprimitivestandardattributes (url: /en-US/docs/Web/API/SVGFilterPrimitiveStandardAttributes) does not exist
    • /en-US/docs/Web/API/SVGFEColorMatrixElement/height does not exist
    • /en-US/docs/Web/API/SVGFEColorMatrixElement/in1 does not exist
    • /en-US/docs/Web/API/SVGFEColorMatrixElement/result does not exist
    • /en-US/docs/Web/API/SVGFEColorMatrixElement/type does not exist
    • and 4 more flaws omitted
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!

URL: /en-US/docs/Web/API/SVGFEMergeElement
Title: SVGFEMergeElement
on GitHub
Flaw count: 6

  • macros:
    • /en-us/docs/web/api/svgfilterprimitivestandardattributes (url: /en-US/docs/Web/API/SVGFilterPrimitiveStandardAttributes) does not exist
    • /en-US/docs/Web/API/SVGFEMergeElement/height does not exist
    • /en-US/docs/Web/API/SVGFEMergeElement/result does not exist
    • /en-US/docs/Web/API/SVGFEMergeElement/width does not exist
    • /en-US/docs/Web/API/SVGFEMergeElement/x does not exist
    • and 1 more flaws omitted

URL: /en-US/docs/Web/API/SVGFEDisplacementMapElement
Title: SVGFEDisplacementMapElement
on GitHub
Flaw count: 11

  • macros:
    • /en-us/docs/web/api/svgfilterprimitivestandardattributes (url: /en-US/docs/Web/API/SVGFilterPrimitiveStandardAttributes) does not exist
    • /en-US/docs/Web/API/SVGFEDisplacementMapElement/height does not exist
    • /en-US/docs/Web/API/SVGFEDisplacementMapElement/in1 does not exist
    • /en-US/docs/Web/API/SVGFEDisplacementMapElement/in2 does not exist
    • /en-US/docs/Web/API/SVGFEDisplacementMapElement/result does not exist
    • and 6 more flaws omitted

URL: /en-US/docs/Web/API/SVGFETileElement
Title: SVGFETileElement
on GitHub
Flaw count: 7

  • macros:
    • /en-us/docs/web/api/svgfilterprimitivestandardattributes (url: /en-US/docs/Web/API/SVGFilterPrimitiveStandardAttributes) does not exist
    • /en-US/docs/Web/API/SVGFETileElement/height does not exist
    • /en-US/docs/Web/API/SVGFETileElement/in1 does not exist
    • /en-US/docs/Web/API/SVGFETileElement/result does not exist
    • /en-US/docs/Web/API/SVGFETileElement/width does not exist
    • and 2 more flaws omitted

URL: /en-US/docs/Web/API/SVGFEOffsetElement
Title: SVGFEOffsetElement
on GitHub
Flaw count: 9

  • macros:
    • /en-us/docs/web/api/svgfilterprimitivestandardattributes (url: /en-US/docs/Web/API/SVGFilterPrimitiveStandardAttributes) does not exist
    • /en-US/docs/Web/API/SVGFEOffsetElement/height does not exist
    • /en-US/docs/Web/API/SVGFEOffsetElement/in1 does not exist
    • /en-US/docs/Web/API/SVGFEOffsetElement/dx does not exist
    • /en-US/docs/Web/API/SVGFEOffsetElement/dy does not exist
    • and 4 more flaws omitted

URL: /en-US/docs/Web/API/SVGFESpecularLightingElement
Title: SVGFESpecularLightingElement
on GitHub
Flaw count: 12

  • macros:
    • /en-us/docs/web/api/svgfilterprimitivestandardattributes (url: /en-US/docs/Web/API/SVGFilterPrimitiveStandardAttributes) does not exist
    • /en-US/docs/Web/API/SVGFESpecularLightingElement/height does not exist
    • /en-US/docs/Web/API/SVGFESpecularLightingElement/in1 does not exist
    • /en-US/docs/Web/API/SVGFESpecularLightingElement/kernelUnitLengthX does not exist
    • /en-US/docs/Web/API/SVGFESpecularLightingElement/kernelUnitLengthY does not exist
    • and 7 more flaws omitted

URL: /en-US/docs/Web/API/SVGFEComponentTransferElement
Title: SVGFEComponentTransferElement
on GitHub
Flaw count: 7

  • macros:
    • /en-us/docs/web/api/svgfilterprimitivestandardattributes (url: /en-US/docs/Web/API/SVGFilterPrimitiveStandardAttributes) does not exist
    • /en-US/docs/Web/API/SVGFEComponentTransferElement/height does not exist
    • /en-US/docs/Web/API/SVGFEComponentTransferElement/in1 does not exist
    • /en-US/docs/Web/API/SVGFEComponentTransferElement/result does not exist
    • /en-US/docs/Web/API/SVGFEComponentTransferElement/width does not exist
    • and 2 more flaws omitted

URL: /en-US/docs/Web/API/SVGFEConvolveMatrixElement
Title: SVGFEConvolveMatrixElement
on GitHub
Flaw count: 18

  • macros:
    • /en-us/docs/web/api/svgfilterprimitivestandardattributes (url: /en-US/docs/Web/API/SVGFilterPrimitiveStandardAttributes) does not exist
    • /en-US/docs/Web/API/SVGFEConvolveMatrixElement/bias does not exist
    • /en-US/docs/Web/API/SVGFEConvolveMatrixElement/divisor does not exist
    • /en-US/docs/Web/API/SVGFEConvolveMatrixElement/edgeMode does not exist
    • /en-US/docs/Web/API/SVGFEConvolveMatrixElement/height does not exist
    • and 13 more flaws omitted

URL: /en-US/docs/Web/API/SVGFEImageElement
Title: SVGFEImageElement
on GitHub
Flaw count: 9

  • macros:
    • /en-us/docs/web/api/svgfilterprimitivestandardattributes (url: /en-US/docs/Web/API/SVGFilterPrimitiveStandardAttributes) does not exist
    • /en-US/docs/Web/API/SVGFEImageElement/crossOrigin does not exist
    • /en-US/docs/Web/API/SVGFEImageElement/height does not exist
    • /en-US/docs/Web/API/SVGFEImageElement/href does not exist
    • /en-US/docs/Web/API/SVGFEImageElement/preserveAspectRatio does not exist
    • and 4 more flaws omitted

URL: /en-US/docs/Web/API/SVGFEBlendElement
Title: SVGFEBlendElement
on GitHub
Flaw count: 9

  • macros:
    • /en-us/docs/web/api/svgfilterprimitivestandardattributes (url: /en-US/docs/Web/API/SVGFilterPrimitiveStandardAttributes) does not exist
    • /en-US/docs/Web/API/SVGFEBlendElement/height does not exist
    • /en-US/docs/Web/API/SVGFEBlendElement/in1 does not exist
    • /en-US/docs/Web/API/SVGFEBlendElement/in2 does not exist
    • /en-US/docs/Web/API/SVGFEBlendElement/mode does not exist
    • and 4 more flaws omitted

URL: /en-US/docs/Web/API/SVGFEMorphologyElement
Title: SVGFEMorphologyElement
on GitHub
Flaw count: 10

  • macros:
    • /en-us/docs/web/api/svgfilterprimitivestandardattributes (url: /en-US/docs/Web/API/SVGFilterPrimitiveStandardAttributes) does not exist
    • /en-US/docs/Web/API/SVGFEMorphologyElement/height does not exist
    • /en-US/docs/Web/API/SVGFEMorphologyElement/in1 does not exist
    • /en-US/docs/Web/API/SVGFEMorphologyElement/operator does not exist
    • /en-US/docs/Web/API/SVGFEMorphologyElement/radiusX does not exist
    • and 5 more flaws omitted

URL: /en-US/docs/Web/API/SVGFEFloodElement
Title: SVGFEFloodElement
on GitHub
Flaw count: 6

  • macros:
    • /en-us/docs/web/api/svgfilterprimitivestandardattributes (url: /en-US/docs/Web/API/SVGFilterPrimitiveStandardAttributes) does not exist
    • /en-US/docs/Web/API/SVGFEFloodElement/height does not exist
    • /en-US/docs/Web/API/SVGFEFloodElement/result does not exist
    • /en-US/docs/Web/API/SVGFEFloodElement/width does not exist
    • /en-US/docs/Web/API/SVGFEFloodElement/x does not exist
    • and 1 more flaws omitted

URL: /en-US/docs/Web/API/SVGFEDropShadowElement
Title: SVGFEDropShadowElement
on GitHub
Flaw count: 12

  • macros:
    • /en-us/docs/web/api/svgfilterprimitivestandardattributes (url: /en-US/docs/Web/API/SVGFilterPrimitiveStandardAttributes) does not exist
    • /en-US/docs/Web/API/SVGFEDropShadowElement/dx does not exist
    • /en-US/docs/Web/API/SVGFEDropShadowElement/dy does not exist
    • /en-US/docs/Web/API/SVGFEDropShadowElement/height does not exist
    • /en-US/docs/Web/API/SVGFEDropShadowElement/in1 does not exist
    • and 7 more flaws omitted

External URLs

URL: /en-US/docs/Web/API/SVGFECompositeElement
Title: SVGFECompositeElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGFETurbulenceElement
Title: SVGFETurbulenceElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGFEDiffuseLightingElement
Title: SVGFEDiffuseLightingElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGFEGaussianBlurElement
Title: SVGFEGaussianBlurElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGFEColorMatrixElement
Title: SVGFEColorMatrixElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGFEMergeElement
Title: SVGFEMergeElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGFEDisplacementMapElement
Title: SVGFEDisplacementMapElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGFETileElement
Title: SVGFETileElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGFEOffsetElement
Title: SVGFEOffsetElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGFESpecularLightingElement
Title: SVGFESpecularLightingElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGFEComponentTransferElement
Title: SVGFEComponentTransferElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGFEConvolveMatrixElement
Title: SVGFEConvolveMatrixElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGFEImageElement
Title: SVGFEImageElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGFEBlendElement
Title: SVGFEBlendElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGFEMorphologyElement
Title: SVGFEMorphologyElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGFEFloodElement
Title: SVGFEFloodElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGFEDropShadowElement
Title: SVGFEDropShadowElement
on GitHub

No new external URLs

(this comment was updated 2021-05-25 18:34:32.802664)
@foolip

foolip commented May 21, 2021

Copy link
Copy Markdown
Contributor Author

@Elchi3 would you care to review? There's no compat data for these members in BCD, do you think we should block this on adding it? Otherwise I'll just remove the SVGFilterPrimitiveStandardAttributes entry in BCD, which in its current form doesn't convey any information.
@Elchi3

Elchi3 commented May 25, 2021

Copy link
Copy Markdown
Member

Thanks Philip, taking a look!

It helps if you provide the IDL, so that one can double check what is going on. This is now a mixin in SVG 2:
https://drafts.fxtf.org/filter-effects/#InterfaceSVGFilterPrimitiveStandardAttributes

Implemented by all filter interfaces:
Interface SVGFEBlendElement
Interface SVGFEColorMatrixElement
Interface SVGFEComponentTransferElement
Interface SVGFECompositeElement
Interface SVGFEConvolveMatrixElement
Interface SVGFEDiffuseLightingElement
Interface SVGFEDisplacementMapElement
Interface SVGFEDropShadowElement
Interface SVGFEFloodElement
Interface SVGFEGaussianBlurElement
Interface SVGFEImageElement
Interface SVGFEMergeElement
Interface SVGFEMorphologyElement
Interface SVGFEOffsetElement
Interface SVGFESpecularLightingElement
Interface SVGFETileElement
Interface SVGFETurbulenceElement

It used to be on the inheritance chain without mixin in SVG 1.1:
https://www.w3.org/TR/SVG11/filters.html#InterfaceSVGFilterPrimitiveStandardAttributes
@Elchi3

Elchi3 commented May 25, 2021

Copy link
Copy Markdown
Member

@Elchi3 would you care to review? There's no compat data for these members in BCD, do you think we should block this on adding it? Otherwise I'll just remove the SVGFilterPrimitiveStandardAttributes entry in BCD, which in its current form doesn't convey any information.

In this case, there are no docs written for any of these things, so I'd say no need to block.
I usually try to create sub pages for mixins whenever I do this work. In this case, we have 17 interfaces implementing the mixin. That's quite a bit of pages to create. I'm not sure what the best approach is but for now I think this PR is a good start.
@foolip

foolip commented May 25, 2021

Copy link
Copy Markdown
Contributor Author

@Elchi3 I would recommend a checkout of https://github.com/w3c/webref/tree/master/ed/idl and grepping in that directory to figure out all the places something is used. It should give the same result as you found, but probably quicker. The matches:

interface mixin SVGFilterPrimitiveStandardAttributes {
SVGFEBlendElement includes SVGFilterPrimitiveStandardAttributes;
SVGFEColorMatrixElement includes SVGFilterPrimitiveStandardAttributes;
SVGFEComponentTransferElement includes SVGFilterPrimitiveStandardAttributes;
SVGFECompositeElement includes SVGFilterPrimitiveStandardAttributes;
SVGFEConvolveMatrixElement includes SVGFilterPrimitiveStandardAttributes;
SVGFEDiffuseLightingElement includes SVGFilterPrimitiveStandardAttributes;
SVGFEDisplacementMapElement includes SVGFilterPrimitiveStandardAttributes;
SVGFEDropShadowElement includes SVGFilterPrimitiveStandardAttributes;
SVGFEFloodElement includes SVGFilterPrimitiveStandardAttributes;
SVGFEGaussianBlurElement includes SVGFilterPrimitiveStandardAttributes;
SVGFEImageElement includes SVGFilterPrimitiveStandardAttributes;
SVGFEMergeElement includes SVGFilterPrimitiveStandardAttributes;
SVGFEMorphologyElement includes SVGFilterPrimitiveStandardAttributes;
SVGFEOffsetElement includes SVGFilterPrimitiveStandardAttributes;
SVGFESpecularLightingElement includes SVGFilterPrimitiveStandardAttributes;
SVGFETileElement includes SVGFilterPrimitiveStandardAttributes;
SVGFETurbulenceElement includes SVGFilterPrimitiveStandardAttributes;
Elchi3
Elchi3 requested changes May 25, 2021
View reviewed changes

@Elchi3 Elchi3 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me, but we order member lists alphabetically. Would you mind sorting them in correctly?
@foolip

foolip commented May 25, 2021

Copy link
Copy Markdown
Contributor Author

Some of the existing lists weren't alphabetical, but I've sorted them all now. Hopefully I haven't accidentally swapped two lines somewhere 😨
Elchi3
Elchi3 approved these changes May 26, 2021
View reviewed changes

@Elchi3 Elchi3 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, great work! 💯
@Elchi3
Elchi3 merged commit df66c89 into mdn:main May 26, 2021
@Elchi3 Elchi3 mentioned this pull request May 26, 2021
Closed
@foolip
foolip deleted the rm-SVGFilterPrimitiveStandardAttributes branch May 26, 2021 20:10
@foolip foolip mentioned this pull request Jun 1, 2021
Closed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants

@foolip @Elchi3