Repository navigation
Fold SVGAnimatedPoints (a mixin) into SVGPolygonElement and SVGPolylineElement - #5181
Conversation
|
@Elchi3 I'm leaving this as a draft pull request since I unfortunately (per habit) looked too closely and discovered something terrible. |
Preview URLs
FlawsURL:
URL:
External URLsURL: No new external URLs URL: No new external URLs (this comment was updated 2021-06-03 07:49:19.021350) |
Looks like a spec change per https://www.w3.org/TR/SVG2/shapes.html#InterfaceSVGAnimatedPoints We probably want to show this spec change in the docs and in BCD then. Currently BCD just says "only implements the SVG 1.1 specification of the interface." which is too abstract. We should talk about this specific change instead I assume. |
|
Aha, so this might be what the notes were about! I frowned and sent a PR to remove them in mdn/browser-compat-data#10560, but maybe it should go together with demixing. |
|
Judging by https://wpt.fyi/results/svg/shapes/animatedPoints-non-animated.html no browser has followed the spec change here, it's just something the spec editors hope for at this point. Should we just document what's actually implemented? |
|
I see. Well, then I guess we should try to document reality and that's SVG 1.1 and implementations and not SVG 2. |
86c01c0 to
0783915
Compare
|
@Elchi3 I've tried to document reality, PTAL. |
Elchi3
left a comment
Elchi3
left a comment
There was a problem hiding this comment.
Thanks for doing this! There is a macro error but LGTM otherwise
|
|
||
| <dl> | ||
| <dt>{{domxref("SVGPolygonElement.animatedPoints")}} {{readOnlyInline}}</dt> | ||
| <dd>A {{DOMxRef("SVGPointList")}} representing the animated value of the element's {{SVGAttr("points")}} attribute. If the { {SVGAttr("points")}} attribute is not being animated, it contains the same value as the <code>points</code> property.</dd> |
There was a problem hiding this comment.
I assume the build fails because you have a line break in a macro call.
There was a problem hiding this comment.
It took me a while to spot, but yeah I had { {.
…neElement Redirect it to SVGPolygonElement, an arbitrary choice between the two. Document animatedPoints in a similar way to animVal here: https://developer.mozilla.org/en-US/docs/Web/API/SVGAnimatedString This ignores that the spec requires animatedPoints to be an alias of points, because that does not match what's actually implemented (yet): https://svgwg.org/svg2-draft/shapes.html#__svg__SVGAnimatedPoints__animatedPoints https://wpt.fyi/results/svg/shapes/animatedPoints-non-animated.html?run_id=5709221590990848&run_id=5697986191425536&run_id=5747784122630144&run_id=5742635329257472
0783915 to
1eb7125
Compare
Elchi3
left a comment
Elchi3
left a comment
There was a problem hiding this comment.
Looking forward to the day we are in markdown and with as little kumascript macros as possible. :-)
Co-authored-by: Florian Scholz <fs@florianscholz.com>
What will xrefs look like with Markdown? Won't it still be a macro that one can mess up? |
Initially, yes, but I hope we won't have xref macros forever. |
Redirect it to SVGPolygonElement, an arbitrary choice between the two.
Document animatedPoints in a similar way to animVal here:
https://developer.mozilla.org/en-US/docs/Web/API/SVGAnimatedString
This ignores that the spec requires animatedPoints to be an alias of
points, because that does not match what's actually implemented (yet):
https://svgwg.org/svg2-draft/shapes.html#__svg__SVGAnimatedPoints__animatedPoints
https://wpt.fyi/results/svg/shapes/animatedPoints-non-animated.html?run_id=5709221590990848&run_id=5697986191425536&run_id=5747784122630144&run_id=5742635329257472