Skip to content

Demix Parentnode.children to Element, Document, DocumentFragment pages - #4065

Merged
chrisdavidmills merged 9 commits into
mdn:mainfrom
Elchi3:demix-parentnode-children
Apr 13, 2021
Merged

chrisdavidmills merged 9 commits into
mdn:mainfrom
Elchi3:demix-parentnode-children

Conversation

@Elchi3

@Elchi3 Elchi3 commented Apr 13, 2021

Copy link
Copy Markdown
Member

Here we are again, refactoring mixin pages.

Now:
https://developer.mozilla.org/en-US/docs/Web/API/ParentNode/children

After:
https://developer.mozilla.org/en-US/docs/Web/API/Element/children
https://developer.mozilla.org/en-US/docs/Web/API/Document/children
https://developer.mozilla.org/en-US/docs/Web/API/DocumentFragment/children

IDL:

interface mixin ParentNode {
  [SameObject] readonly attribute HTMLCollection children;
};
Document includes ParentNode;
DocumentFragment includes ParentNode;
Element includes ParentNode;
@Elchi3
Elchi3 requested review from a team and chrisdavidmills and removed request for a team April 13, 2021 11:22
@github-actions

Copy link
Copy Markdown
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Web/API/Document
Title: Document
on GitHub
Flaw count: 166

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • and 133 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/XUL_Overlays
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 22 more flaws omitted

URL: /en-US/docs/Web/API/Document/children
Title: Document.children
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/API/DocumentFragment
Title: DocumentFragment
on GitHub
Flaw count: 6

  • macros:
    • /en-US/docs/Web/API/DocumentFragment/getElementById does not exist
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!

URL: /en-US/docs/Web/API/DocumentFragment/children
Title: DocumentFragment.children
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/API/Element
Title: Element
on GitHub
Flaw count: 9

  • macros:
    • /en-us/docs/web/api/animatable (url: /en-US/docs/Web/API/Animatable) does not exist
    • /en-US/docs/Web/API/GlobalEventHandlers/onshow does not exist
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 2 more flaws omitted

URL: /en-US/docs/Web/API/Element/children
Title: Element.children
on GitHub
Flaw count: 1

  • macros:
    • /en-us/docs/web/api/animatable (url: /en-US/docs/Web/API/Animatable) does not exist

URL: /en-US/docs/Web/API/Node/childNodes
Title: Node.childNodes
on GitHub

No flaws! 🎉

External URLs

URL: /en-US/docs/Web/API/Document
Title: Document
on GitHub


URL: /en-US/docs/Web/API/Document/children
Title: Document.children
on GitHub


URL: /en-US/docs/Web/API/DocumentFragment
Title: DocumentFragment
on GitHub


URL: /en-US/docs/Web/API/DocumentFragment/children
Title: DocumentFragment.children
on GitHub


URL: /en-US/docs/Web/API/Element
Title: Element
on GitHub


URL: /en-US/docs/Web/API/Element/children
Title: Element.children
on GitHub


URL: /en-US/docs/Web/API/Node/childNodes
Title: Node.childNodes
on GitHub

@github-actions

Copy link
Copy Markdown
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Web/API/Document
Title: Document
on GitHub
Flaw count: 166

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • and 133 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/XUL_Overlays
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 22 more flaws omitted

URL: /en-US/docs/Web/API/Document/children
Title: Document.children
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/API/DocumentFragment
Title: DocumentFragment
on GitHub
Flaw count: 6

  • macros:
    • /en-US/docs/Web/API/DocumentFragment/getElementById does not exist
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!

URL: /en-US/docs/Web/API/DocumentFragment/children
Title: DocumentFragment.children
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/API/Element
Title: Element
on GitHub
Flaw count: 9

  • macros:
    • /en-us/docs/web/api/animatable (url: /en-US/docs/Web/API/Animatable) does not exist
    • /en-US/docs/Web/API/GlobalEventHandlers/onshow does not exist
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 2 more flaws omitted

URL: /en-US/docs/Web/API/Element/children
Title: Element.children
on GitHub
Flaw count: 1

  • macros:
    • /en-us/docs/web/api/animatable (url: /en-US/docs/Web/API/Animatable) does not exist

URL: /en-US/docs/Web/API/Node/childNodes
Title: Node.childNodes
on GitHub

No flaws! 🎉

External URLs

URL: /en-US/docs/Web/API/Document
Title: Document
on GitHub


URL: /en-US/docs/Web/API/Document/children
Title: Document.children
on GitHub


URL: /en-US/docs/Web/API/DocumentFragment
Title: DocumentFragment
on GitHub


URL: /en-US/docs/Web/API/DocumentFragment/children
Title: DocumentFragment.children
on GitHub


URL: /en-US/docs/Web/API/Element
Title: Element
on GitHub


URL: /en-US/docs/Web/API/Element/children
Title: Element.children
on GitHub


URL: /en-US/docs/Web/API/Node/childNodes
Title: Node.childNodes
on GitHub

@chrisdavidmills chrisdavidmills left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great; thank you so much @Elchi3 !

@chrisdavidmills
chrisdavidmills merged commit 61f767f into mdn:main Apr 13, 2021
@Elchi3
Elchi3 deleted the demix-parentnode-children branch April 13, 2021 12:20
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants