Repository navigation
FF123 updates for permission publickey-credentials-create - #32135
Merged
Merged
Conversation
hamishwillee
requested review from
a team,
chrisdavidmills,
teoli2003 and
wbamberg
and removed request for
a team
February 6, 2024 04:25
github-actions
Bot
added
Content:WebAPI
Contributor
hamishwillee
commented
Feb 6, 2024
10 tasks done
dasJ
reviewed
Feb 6, 2024
hamishwillee
commented
Feb 9, 2024
hamishwillee
commented
Feb 9, 2024
hamishwillee
commented
Feb 9, 2024
hamishwillee
commented
Feb 9, 2024
Collaborator
Author
wbamberg
reviewed
Feb 9, 2024
dasJ
reviewed
Feb 9, 2024
wbamberg
reviewed
Feb 9, 2024
github-actions
Bot
added
size/m
![github-actions[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: wbamberg <will@bootbonnet.ca>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
hamishwillee
force-pushed
the
ff123_credentials_create
branch
from
February 12, 2024 20:47
56eef41 to
2959b46
Compare
Collaborator
Author
|
@wbamberg Anything else needed here (when you have a moment) |
wbamberg
previously requested changes
Feb 13, 2024
wbamberg
left a comment
wbamberg
left a comment
Collaborator
There was a problem hiding this comment.
Just a couple of nits.
Co-authored-by: wbamberg <will@bootbonnet.ca>
Collaborator
Author
|
No, thanks for your patience and help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FF123 supports Feature policy
publickey-credentials-createin https://bugzilla.mozilla.org/show_bug.cgi?id=1870863As per usual for FF, this can't be set on the header, but only via
allowon the frame.This attempts to update the docs with some corrections according to advice from engineers and my interpretation of the spec. Note that I think there are probably more relevant exceptions, but I don't propose to go through all the specs right now.
The specific issues fixed are:
SecurityError. Spec saysNotAllowedErrorin step 5 herecreate()in an iframe, but that was changed in WebAuthn spec in Allow for credential creation in a cross-origin iframe w3c/webauthn#1801 and to the Credential Management spec in Add support for publickey-credentials-create permission policy w3c/webappsec-credential-management#209. I added some examples.I'm seeing confirmation from engineers too in https://bugzilla.mozilla.org/show_bug.cgi?id=1870863#c7 but the spec seems fairly clear on the NotAllowedError and transient activation.
Other docs work can be tracked in #31890