Repository navigation
Flatten HTMLHyperlinkElementUtils mixin to HTMLAnchorElement/HTMLAreaElement - #8933
Merged
Merged
Conversation
github-actions
Bot
added
the
data:api
Member
Author
|
Reviewers: Please leave your feedback in the issue: #8929 |
Member
Author
|
Seems like there is consensus on this approach so marking as ready for review. Might be blocked by getting the data guideline merged, though (#9016) |
ddbeck
approved these changes
Feb 11, 2021
ddbeck
left a comment
ddbeck
left a comment
Contributor
There was a problem hiding this comment.
Looks great!
Should we bump the version number to 3.1.0 for this?
Member
Author
According to #472 (comment), about 21 mixins are affected by this (although we already agreed that some larger mixins (workers) probably need special treatment. So, I assume something like 100-300 features are affected? (out of 12,000). So, yeah, could do a minor bump, I don't think it's major. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proof of concept for #8929
Currently, BCD exposes
api.HTMLHyperlinkElementUtils, a non-observable mixin and no real JS interface/class/object.api.HTMLHyperlinkElementUtils.href
api.HTMLHyperlinkElementUtils.origin
api.HTMLHyperlinkElementUtils.protocol
api.HTMLHyperlinkElementUtils.username
api.HTMLHyperlinkElementUtils.password
api.HTMLHyperlinkElementUtils.host
api.HTMLHyperlinkElementUtils.hostname
api.HTMLHyperlinkElementUtils.port
api.HTMLHyperlinkElementUtils.pathname
api.HTMLHyperlinkElementUtils.search
api.HTMLHyperlinkElementUtils.hash
With this change, BCD extends HTMLAnchorElement and HTMLAreaElement and exposes instead:
api.HTMLAnchorElement.href
api.HTMLAnchorElement.origin
api.HTMLAnchorElement.protocol
api.HTMLAnchorElement.username
api.HTMLAnchorElement.password
api.HTMLAnchorElement.host
api.HTMLAnchorElement.hostname
api.HTMLAnchorElement.port
api.HTMLAnchorElement.pathname
api.HTMLAnchorElement.search
api.HTMLAnchorElement.hash
api.HTMLAreaElement.href
api.HTMLAreaElement.origin
api.HTMLAreaElement.protocol
api.HTMLAreaElement.username
api.HTMLAreaElement.password
api.HTMLAreaElement.host
api.HTMLAreaElement.hostname
api.HTMLAreaElement.port
api.HTMLAreaElement.pathname
api.HTMLAreaElement.search
api.HTMLAreaElement.hash
It does so by having two files in the
/api/_mixins/folder:HTMLHyperlinkElementUtils__HTMLAnchorElement.jsonHTMLHyperlinkElementUtils__HTMLAreaElement.json