fix(islands): add missing type field to control requests #8071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Islands bridge was sending control requests without the required `type` discriminator field, causing msgspec.ValidationError in the kernel and breaking all widget interactivity (sliders, dataframe sorting, etc.). Changes: - Add type field to sendComponentValues, sendFunctionRequest, sendRun, and sendModelValue methods - Add token generation to sendComponentValues for consistency with WASM bridge - Improve type safety by using CommandMessage instead of object - Add unit tests for bridge control request formatting Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mscolnick
approved these changes
Jan 31, 2026
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.19.8-dev4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes widget interactivity (sliders, dataframe sorting, etc.) in Islands mode by adding the required
typediscriminator field to control request messages.The Islands bridge was sending control requests like:
{"objectIds":["Hbol-0"],"values":[58]}But the kernel's msgspec parser expects:
{"type":"update-ui-element","objectIds":["Hbol-0"],"values":[58]}Without the
typefield, msgspec throwsValidationError: Object missing required field 'type'.Changes
typefield tosendComponentValues,sendFunctionRequest,sendRun, andsendModelValuetoken: generateUUID()tosendComponentValuesfor consistency with WASM bridgeputControlRequestnow usesCommandMessageinstead ofobjectContext
I discovered this bug while working on a project using marimo Islands. This PR was live-coded in ~20 minutes with Claude Code, including two rounds of external agent code reviews. I had minimal prior familiarity with this part of the codebase - just noticed the error in the console and traced it back to the missing
typefield by comparing with the WASM bridge implementation.Test plan
🤖 Generated with Claude Code