Skip to content

remove manual handling of local iframes, only external iframes #8051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mscolnick merged 1 commit into from
Jan 29, 2026
Merged

remove manual handling of local iframes, only external iframes #8051

mscolnick merged 1 commit into from
Jan 29, 2026

Conversation

@Light2Dark
Copy link
Contributor

@Light2Dark Light2Dark commented Jan 29, 2026

📝 Summary

html-to-image can handle local iframes. So we only handle for external iframes. This avoids issues if element + local iframes in the same element

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • Tests have been added for the changes made.
  • Documentation has been updated where applicable, including docstrings for API changes.
  • Pull request title is a good summary of the changes - it will be used in the release notes.
@Light2Dark Light2Dark requested a review from manzt as a code owner January 29, 2026 16:16
@vercel
Copy link

vercel bot commented Jan 29, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
marimo-docs Ready Ready Preview, Comment Jan 29, 2026 4:16pm

Request Review
@Light2Dark Light2Dark added the bug Something isn't working label Jan 29, 2026
@Light2Dark Light2Dark requested review from mscolnick and removed request for manzt January 29, 2026 16:17
@Light2Dark Light2Dark changed the title remove handling of local iframes, only external iframes for screenshot Jan 29, 2026
@mscolnick mscolnick merged commit 984b0ab into main Jan 29, 2026
36 of 38 checks passed
@mscolnick mscolnick deleted the sham/handle-external-iframes-only branch January 29, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

3 participants

@Light2Dark @mscolnick