improvement: lsp status icon and refresh #8011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
manzt
reviewed
Jan 28, 2026
Contributor
manzt
left a comment
manzt
left a comment
There was a problem hiding this comment.
This is nice! Just a couple comments re the new message types.
marimo/_server/models/lsp.py
Outdated
| import msgspec | ||
|
|
||
|
|
||
| class LspServerHealth(msgspec.Struct, rename="camel"): |
Contributor
There was a problem hiding this comment.
These booleans (is_running, is_responsive, has_failed) have some overlap. VS Code's LSP client uses a status enum, which we could similarly:
class LspServerHealth(msgspec.Struct, rename="camel"):
"""Health status for a single LSP server.
Status meanings:
- starting: process launched, initializing
- running: healthy and responsive to pings
- stopped: not running (never started or cleanly stopped)
- crashed: exited with non-zero code
- unresponsive: process alive but not responding to pings
"""
server_id: str
status: Literal["starting", "running", "stopped", "crashed", "unresponsive"]
port: int
last_ping_ms: Optional[float] = None
error: Optional[str] = None # Why it crashed/stoppedWe could also consider started_at:
started_at: Optional[float] = None # Unix timestampwhich gives us uptime for free (frontend can show "running for 5m" or detect restart loops).
marimo/_server/models/lsp.py
Outdated
| class LspRestartRequest(msgspec.Struct, rename="camel"): | ||
| """Request to restart LSP servers.""" | ||
|
|
||
| server_ids: Optional[list[str]] = None # None = restart failed servers |
Contributor
There was a problem hiding this comment.
Is it worth making a ServerId NewType or at least a TypeAlias scoped to this module?
ServerId = typing.NewType("ServerId", str)msgspec handles these fine.
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.19.7-dev37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the status icon and allow users to click to refresh if there are any issues.