fix: save content when creating a new file via filename input #8009
+18
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a new notebook and naming it via the filename input in the header, the file was created empty because only the rename operation was performed. The cell content required a separate save action (Ctrl+S). This change modifies `FilenameForm` to also save the notebook content after renaming, when the notebook was previously unnamed. This matches the behavior of the Save dialog (Ctrl+S on unnamed notebooks). Closes #7981
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Light2Dark
approved these changes
Jan 28, 2026
Contributor
Light2Dark
left a comment
Light2Dark
left a comment
There was a problem hiding this comment.
lgtm, I think a test could be added, to see if mockSaveNotebook was called for this path
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.19.7-dev24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new notebook and naming it via the filename input in the
header, the file was created empty because only the rename operation
was performed. The cell content required a separate save action (Ctrl+S).
This change modifies
FilenameFormto also save the notebook contentafter renaming, when the notebook was previously unnamed. This matches
the behavior of the Save dialog (Ctrl+S on unnamed notebooks).
Closes #7981