Correct input channel direction for IPC sandbox mode #7973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #7972 Fixes marimo-team/marimo-lsp#176 The input channel for Python's `input()` had its Push/Pull directions inverted between the host and kernel sides of the ZeroMQ connection. The host should Push input to the kernel, and the kernel should Pull to receive it. This caused `input()` to fail with "PushQueue does not support get operations" when using `marimo edit --sandbox <directory>` or the VS Code extension.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 task
manzt
force-pushed
the
push-ymlxsuqvwusx
branch
from
33acf43 to
1c71138
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes IPC sandbox-mode input() by correcting the ZeroMQ Push/Pull direction for the input channel so the host sends input to the kernel and the kernel receives it.
Changes:
- Swap
inputchannel direction inConnection.create()/Connection.connect()(host Push, kernel Pull). - Add a regression test verifying host→kernel input flow for the IPC connection.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
marimo/_ipc/connection.py |
Corrects the input channel socket direction to match intended host→kernel data flow. |
tests/_session/managers/test_ipc.py |
Adds a regression test covering the corrected input-channel direction and updates ZMQ test gating. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mscolnick
approved these changes
Jan 26, 2026
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.19.7-dev4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7972
Fixes marimo-team/marimo-lsp#176
The input channel for Python's
input()had its Push/Pull directions inverted between the host and kernel sides of the ZeroMQ connection. The host should Push input to the kernel, and the kernel should Pull to receive it.This caused
input()to fail with "PushQueue does not support get operations" when usingmarimo edit --sandbox <directory>or the VS Code extension.