-
Notifications
You must be signed in to change notification settings - Fork 892
Refine rendering of equations in chat pane #7961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
frontend/package.json
Outdated
| "vega-tooltip": "^1.1.0", | ||
| "vscode-jsonrpc": "^8.2.1", | ||
| "vscode-languageserver-protocol": "^3.17.5", | ||
| "vscode-languageserver-types": "^3.17.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this added with the upgrade & install?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, I've just updated my PR so dependency changes are minimal. I'm not commiting the lock files as well. I've also tested that the fix still works, it's quite nice to see all equations including inline ones well formatted in the chat pane.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lock files do need to be committed, since the deps have changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
0b5b0e6 to
c2128e5
Compare
c2128e5 to
05027c3
Compare
|
It seems that there is a test error unrelated to my PR |
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.19.7-dev16 |
📝 Summary
Closes #7935
🔍 Description of Changes
Summary
Enable LaTeX math rendering in the marimo chat pane by integrating the
streamdownmath plugin and updating AI system prompts.Changes
Frontend
@streamdown/mathdependency and enabled it in theMarkdownRenderercomponent.streamdownto^2.1.0to support thepluginsarchitecture required for LaTeX.Backend
marimo/_server/ai/prompts.pyto instruct the LLM to use double dollar signs ($$) for both inline and block mathematical expressions, ensuring compatibility with thestreamdownmath plugin.tests/_server/ai/test_prompts.pyto verify that markdown rules correctly include LaTeX instructions, and updated prompt snapshots.Workspace
pnpm-lock.yamlandpixi.lockafter successful workspace-wide dependency installation.Test plan
make dev.$delimiters$.📋 Checklist