-
Notifications
You must be signed in to change notification settings - Fork 892
fix: fail CLI edit if shared memory is not available #7921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fail CLI edit if shared memory is not available #7921
Conversation
marimo edit today requires shared memory; this change updates the CLI to exit with an informative error if we detect that shared memory is not available This fixes an issue in which running marimo on minimal sandboxes that don't have /dev/shm led to a confusing error state, with the frontend repeatedly failing to connect.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
for more information, see https://pre-commit.ci
…github.com:marimo-team/marimo into aka/fix-fail-fast-when-shared-memory-not-available
| " - If running in Docker, ensure /dev/shm is mounted with sufficient size\n" | ||
| " (e.g., --shm-size=256m or -v /dev/shm:/dev/shm)\n" | ||
| " - If /dev/shm is full, clear unused shared memory segments\n" | ||
| " - Use 'marimo run' instead if you only need to view notebooks" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another option is to warn and then disable virtualfiles (we do support disabling virtual files and it will inline data)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh interesting. I think this is fine for now, but if someone opens an issue we can consider
|
Failing test looks unrelated (this PR does not have API changes) |
marimo edit today requires shared memory; this change updates the CLI to exit with an informative error if we detect that shared memory is not available This fixes an issue in which running marimo on minimal sandboxes that don't have /dev/shm led to a confusing error state, with the frontend repeatedly failing to connect. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
marimo edit today requires shared memory; this change updates the CLI to exit with an informative error if we detect that shared memory is not available This fixes an issue in which running marimo on minimal sandboxes that don't have /dev/shm led to a confusing error state, with the frontend repeatedly failing to connect. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
marimo edit today requires shared memory; this change updates the CLI to exit with an informative error if we detect that shared memory is not available
This fixes an issue in which running marimo on minimal sandboxes that don't have /dev/shm led to a confusing error state, with the frontend repeatedly failing to connect.