Skip to content

remove width param for data editor #7741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mscolnick merged 1 commit into from
Jan 8, 2026
Merged

remove width param for data editor #7741

mscolnick merged 1 commit into from
Jan 8, 2026
+0 −1

Conversation

@Light2Dark
Copy link
Contributor

@Light2Dark Light2Dark commented Jan 8, 2026 •
edited
Loading

📝 Summary

Fixes #7734

in hstack
image

normal
image

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.
@Light2Dark Light2Dark requested a review from manzt as a code owner January 8, 2026 16:07
@vercel
Copy link

vercel bot commented Jan 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
marimo-docs Ready Ready Preview, Comment Jan 8, 2026 4:07pm
@Light2Dark Light2Dark added the bug Something isn't working label Jan 8, 2026
@mscolnick mscolnick merged commit 9171a7a into main Jan 8, 2026
35 of 38 checks passed
@mscolnick mscolnick deleted the sham/fix-data-editor-width branch January 8, 2026 17:29
Light2Dark added a commit that referenced this pull request Jan 8, 2026
@Light2Dark
Revert "remove width param for data editor (#7741)"
ee4bb59 
This reverts commit 9171a7a.
@Light2Dark Light2Dark mentioned this pull request Jan 8, 2026
Merged
mscolnick pushed a commit that referenced this pull request Jan 8, 2026
@Light2Dark
Revert "remove width param for data editor" (#7747)
5806a89 
This clamps the width for data-editor when it's small. Needs a more
robust solution

<img width="943" height="284" alt="image"
src="https://github.com/user-attachments/assets/26620308-3d98-49c5-bd91-698331cedde9"
/>

Reverts #7741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

3 participants

@Light2Dark @mscolnick