fix path resolution for .resolve() and .absolute() for correctness and security #7703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d security The codebase was using `Path.resolve()` and `Path.absolute()` inconsistently, leading to: - **Unexpected behavior**: Symlinked directories resolved to their real paths, breaking user expectations - **Unnormalized paths**: `Path.absolute()` doesn't normalize `..` and `.` components, leaving messy paths in sys.path and other places. - **Security vulnerability**: `Path.resolve()` follows symlinks, which could allow traveral attacks - however, in these instances, the user already has full access to the system so there was no additional risk. This PR adds `normalize_path()` utility that converts relative paths to absolute and normalizes `..` and `.` components using `os.path.normpath()`, but does not resolve symlinks.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.18.5-dev153 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codebase was using
Path.resolve()andPath.absolute()inconsistently, leading to:Path.absolute()doesn't normalize..and.components, leaving messy paths in sys.path and other places.Path.resolve()follows symlinks, which could allow traveral attacks - however, in these instances, the user already has full access to the system so there was no additional risk.This PR adds
normalize_path()utility that converts relative paths to absolute and normalizes..and.components usingos.path.normpath(), but does not resolve symlinks.