fix: specific handling for lazy requests #7698
Merged
+1,230
−401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This comment was marked as duplicate.
This comment was marked as duplicate.
mscolnick
commented
Jan 6, 2026
frontend/src/components/editor/chrome/wrapper/footer-items/runtime-settings.tsx
Show resolved
Hide resolved
This comment was marked as duplicate.
This comment was marked as duplicate.
2 similar comments
This comment was marked as duplicate.
This comment was marked as duplicate.
|
Breaking changes detected in the OpenAPI specification! ==========================================================================
|
Collaborator
|
Breaks |
Contributor
Author
|
@dmadisetti, thanks fixed |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.18.5-dev149 |
manzt
reviewed
Jan 7, 2026
Contributor
manzt
left a comment
manzt
left a comment
There was a problem hiding this comment.
Sorry for the post-merge review. Nice implementation, just a couple clarifying comments.
| // Start connection and wait for it to be open | ||
| await initOnce(runtimeManager); | ||
| await waitForConnectionOpen(); | ||
| if (key !== "sendInstantiate") { |
Contributor
There was a problem hiding this comment.
Maybe worth adding a comment explaining why sendInstantiate is exempt (it's the one that creates the instantiation?)
|
|
||
| switch (action) { | ||
| case "dropRequest": | ||
| // Silently drop the request |
Comment on lines
+15
to
+19
| // We have various requests that act different when called and not connected to a Kernel. They are: | ||
| // - throw an Error | ||
| // - drop the request | ||
| // - start the connection | ||
| // - wait for the connection to be open |
Contributor
There was a problem hiding this comment.
Suggested change
| // We have various requests that act different when called and not connected to a Kernel. They are: | |
| // - throw an Error | |
| // - drop the request | |
| // - start the connection | |
| // - wait for the connection to be open | |
| // We have various requests that act differently when called and not connected to a Kernel: | |
| // | |
| // - throwError: Throws NoKernelConnectedError, caught by requests-toasting.tsx | |
| // and shown as a toast with a "Connect" button. Use for operations that | |
| // shouldn't silently fail but also shouldn't auto-start the kernel. | |
| // | |
| // - dropRequest: Silently returns undefined. Only for requests where failure is | |
| // expected and doesn't matter (e.g., background polling). | |
| // | |
| // - startConnection: Initializes the runtime and waits for connection before | |
| // executing. Use for user-initiated actions that should "just work" and | |
| // kick off the kernel if needed (e.g., clicking Run). | |
| // | |
| // - waitForConnectionOpen: Waits for an existing connection but won't start one. | |
| // Use for operations that depend on a running kernel but shouldn't be the | |
| // trigger to start it (e.g., saving, interrupting). |
Contributor
Author
There was a problem hiding this comment.
thanks, great comments, followed up with all them here: #7710
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each request now will either:
"throwError" | "dropRequest" | "startConnection" | "waitForConnectionOpen". This is a bit cumbersome to manage but i think getting it right will have a good UX. For example, we can let the user type and make edits, but not start the kernel. Once the user hits "run", then we can actually start the kernel.