Combine "Variables" & "Data Sources" panels into "Variables & Data Sources" panel #7459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
manzt
force-pushed
the
manzt/combine-variables-and-data-sources
branch
from
7e02ed9 to
c67cc48
Compare
manzt
force-pushed
the
manzt/combine-variables-and-data-sources
branch
from
c67cc48 to
3978c29
Compare
manzt
force-pushed
the
manzt/combine-variables-and-data-sources
branch
from
3978c29 to
ac2b2d0
Compare
manzt
force-pushed
the
manzt/combine-variables-and-data-sources
branch
from
7ea9b6d to
822c42e
Compare
manzt
force-pushed
the
manzt/combine-variables-and-data-sources
branch
from
822c42e to
a0bca62
Compare
Contributor
|
My only thought is for users who refer to data sources constantly, keeping it closed every time the panel is opened wouldn't be great. We could store it's state in local storage? |
mscolnick
reviewed
Dec 11, 2025
| const variables = useVariables(); | ||
| const cellIds = useCellIds(); | ||
| const datasets = useDatasets(); | ||
| const [openSections, setOpenSections] = useState<string[]>(["variables"]); |
Contributor
There was a problem hiding this comment.
+1 to store this in localstorage. i (n=1) use datasources much more than the variables
manzt
force-pushed
the
manzt/developer-panel
branch
from
8b598e7 to
c299d07
Compare
manzt
force-pushed
the
manzt/combine-variables-and-data-sources
branch
from
a0bca62 to
17ca970
Compare
mscolnick
reviewed
Dec 12, 2025
| Icon: DatabaseIcon, | ||
| tooltip: "Explore data sources", | ||
| Icon: VariableIcon, | ||
| tooltip: "Explore session", |
Contributor
There was a problem hiding this comment.
this will make using the command palette much harder (since you cannot search variables or datasources to find this panel)
Contributor
There was a problem hiding this comment.
is Explore variables and datasources too verbose?
Contributor
Author
There was a problem hiding this comment.
Ok to have a follow up PR for the commandn palette? I updated the tooltip to "Explore variables and datasources"
manzt
force-pushed
the
manzt/combine-variables-and-data-sources
branch
from
17ca970 to
e7a4a44
Compare
manzt
force-pushed
the
manzt/developer-panel
branch
from
c299d07 to
9f2f110
Compare
manzt
force-pushed
the
manzt/developer-panel
branch
from
9f2f110 to
775038e
Compare
manzt
force-pushed
the
manzt/combine-variables-and-data-sources
branch
from
e7a4a44 to
8ceb948
Compare
manzt
force-pushed
the
manzt/combine-variables-and-data-sources
branch
from
8ceb948 to
b5b1403
Compare
manzt
force-pushed
the
manzt/developer-panel
branch
from
775038e to
8743f2d
Compare
manzt
force-pushed
the
manzt/combine-variables-and-data-sources
branch
from
87917dd to
c8e1450
Compare
manzt
force-pushed
the
manzt/combine-variables-and-data-sources
branch
from
789cefd to
136e69c
Compare
The footer now has a single button to toggle the developer panel. It shows a terminal icon normally, or an error icon with count when there are errors. Either way, clicking toggles the panel. The developer panel's Errors tab shows a red dot indicator when there are errors, even when viewing other tabs. Add spacing to developer button
The kernel health indicator has moved from the footer into the developer panel header, next to the tabs. This keeps the footer minimal while still making health status accessible when debugging.
These changes introduce a new "Session" panel that combines what were previously separate "Variables" and "Data Sources" panels into a single view with collapsible accordion sections. Data Sources appears first and is collapsed by default, showing a badge with the count when collapsed. Variables is expanded by default. This reduces sidebar icon count while keeping both features easily accessible.
manzt
force-pushed
the
manzt/combine-variables-and-data-sources
branch
from
136e69c to
7ab9040
Compare
akshayka
previously approved these changes
Dec 26, 2025
manzt
force-pushed
the
manzt/combine-variables-and-data-sources
branch
from
7ab9040 to
307e851
Compare
manzt
force-pushed
the
manzt/combine-variables-and-data-sources
branch
from
63e210c to
ebd354a
Compare
mscolnick
approved these changes
Dec 26, 2025
mscolnick
reviewed
Dec 26, 2025
| import { useVariables } from "@/core/variables/state"; | ||
| import { jotaiJsonStorage } from "@/utils/storage/jotai"; | ||
|
|
||
| const openSectionsAtom = atomWithStorage<string[]>( |
Contributor
There was a problem hiding this comment.
maybe this could be typesafe strings
mscolnick
reviewed
Dec 26, 2025
|
|
||
| const { isFetching, error, data, refetch } = useAsyncData(async () => { | ||
| if (connection !== WebSocketState.OPEN) { | ||
| store.set(connectionStatusAtom, "disconnected"); |
Contributor
There was a problem hiding this comment.
rather than gabbing the store, could we use useSetAtom?
mscolnick
reviewed
Dec 26, 2025
| const sidebarRef = React.useRef<ImperativePanelHandle>(null); | ||
| const terminalRef = React.useRef<ImperativePanelHandle>(null); | ||
| const { aiPanelTab, setAiPanelTab } = useAiPanelTab(); | ||
| const errorCount = useAtomValue(cellErrorCount); |
Contributor
There was a problem hiding this comment.
not sure if its possible to push this down, but errors will create re-renders here (but they are really cheap)
Persist open/closed section state in localStorage so users don't need to re-open data sources each time. Update tooltip to "Explore variables and data sources" for command palette discoverability.
manzt
force-pushed
the
manzt/combine-variables-and-data-sources
branch
from
ebd354a to
da5f272
Compare
manzt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes introduce a new "Session" panel that combines what were previously separate "Variables" and "Data Sources" panels into a single view with collapsible accordion sections. Data Sources appears first and is collapsed by default, showing a badge with the count when collapsed. Variables is expanded by default. This reduces sidebar icon count while keeping both features easily accessible.