-
Notifications
You must be signed in to change notification settings - Fork 812
Altair embed options to remove actions #7277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| return { | ||
| source: false, | ||
| compiled: false, | ||
| ...embedOptions, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this spread be here? i think we can just return:
{
source: false,
compiled: false,
}
|
@copilot can you fix the typecheck issues and commit directly |
|
@mscolnick I've opened a new pull request, #7285, to work on those changes. Once the pull request is ready, I'll request review from you. |
- [x] Understand the problem: typecheck error in vega-component.tsx - [x] Fix the type error for `actions` variable (line 251) - [x] Run typecheck to verify the fix - [x] Improve type assertion to include all action options - [x] Reply to the comment with the fix <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mscolnick <2753772+mscolnick@users.noreply.github.com>
|
I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
for more information, see https://pre-commit.ci
Altair has an annoying default
The normal fix in altair is to declare this:
However, this effect is ignored when we do
mo.ui.altair_chartover any altair chart. This PR fixes that.Note
Propagates Altair renderer embed_options (e.g., actions=False) to the frontend Vega component and uses them to control VegaLite embed actions.
embedOptionsto plugin validator andDatainterface; plumb throughVegaPlugin->VegaComponent->LoadedVegaComponent.actionsfromembedOptions.actionswhen provided; default to{ source: false, compiled: false }otherwise. Remove hardcodedactionsconstant.alt.renderers.options["embed_options"]if set and include as"embed-options"in component args.Written by Cursor Bugbot for commit befb438. This will update automatically on new commits. Configure here.