Skip to content

prevent layout shift from new cell buttons #7276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 24, 2025
Merged

prevent layout shift from new cell buttons #7276

merged 2 commits into from
Nov 24, 2025

Conversation

@Light2Dark
Copy link
Contributor

@Light2Dark Light2Dark commented Nov 24, 2025 •
edited
Loading

📝 Summary

issue:

Screen.Recording.2025-11-24.at.10.56.50.PM.mov

There is a layout shift because the cell buttons which have display: none now appear on hover. This adds a min height to the cell buttons wrapper.

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.
@vercel
Copy link

vercel bot commented Nov 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Nov 24, 2025 2:56pm
@Light2Dark Light2Dark marked this pull request as ready for review November 24, 2025 14:57
@Light2Dark Light2Dark requested a review from manzt as a code owner November 24, 2025 14:57
@mscolnick mscolnick merged commit bde278b into main Nov 24, 2025
26 checks passed
@mscolnick mscolnick deleted the sham/prevent-layout-shift-cell-buttons branch November 24, 2025 15:21
@Light2Dark Light2Dark added the bug Something isn't working label Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

3 participants

@Light2Dark @mscolnick