fix: recognize class variables used within class scope as non-external dependencies (#7265) #7273
Conversation
…l dependencies (#7265) ## Summary Fixes #7265 When a class had a class variable (like `A: int = 1`) and that variable was referenced within the class scope (e.g., in method default parameters or other class variable definitions), marimo incorrectly concluded the class definition could not be reused. This was because `A` was being treated as an external dependency rather than a class-scoped variable.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on December 22
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| unbounded_refs |= data.required_refs - class_def | ||
| # Add the variable to class_def so that later references | ||
| # to it don't create unbounded refs | ||
| class_def.add(var) |
There was a problem hiding this comment.
Bug: Line executed multiple times inside loop
The statement unbounded_refs |= mock_visitor.refs - ignore_refs is executed inside the outer for var in mock_visitor.variable_data: loop, causing it to run once per class variable instead of once total. This incorrectly adds mock_visitor.refs - ignore_refs to unbounded_refs multiple times. The line needs to be moved outside the outer loop to execute only after all variables have been processed.
dmadisetti
left a comment
dmadisetti
left a comment
There was a problem hiding this comment.
This is great, way simpler than I thought. Kudos!
Summary
Fixes #7265
When a class had a class variable (like
A: int = 1) and that variable was referenced within the class scope (e.g., in method default parameters or other class variable definitions), marimo incorrectly concluded the class definition could not be reused. This was becauseAwas being treated as an external dependency rather than a class-scoped variable.