Skip to content

columns.tsx LocaleNumber to use maximumFractionalDigits #7263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 25, 2025
+169 −23
Merged

columns.tsx LocaleNumber to use maximumFractionalDigits #7263

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6eab85b
columns.tsx LocaleNumber to use maximumFractionalDigits
patyork Nov 22, 2025
01abd09
Performance: moved expensive function to Column level
patyork Nov 23, 2025
ed48f76
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 23, 2025
8a89652
fix
mscolnick Nov 25, 2025
0d29efb
tests
mscolnick Nov 25, 2025
69f8f7d
lint
mscolnick Nov 25, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[pre-commit.ci] auto fixes from pre-commit.com hooks 
for more information, see https://pre-commit.ci
  • Loading branch information
@pre-commit-ci
pre-commit-ci[bot] committed Nov 23, 2025
commit ed48f7654a664bb6763e5e41673002d0d69b1bd3
14 changes: 11 additions & 3 deletions frontend/src/components/data-table/columns.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@
isCellSelected,
);

const maxDisplayPrecision = maxFractionalDigits(useLocale().locale);

Check failure on line 254 in frontend/src/components/data-table/columns.tsx

View workflow job for this annotation

GitHub Actions / 🧹 Lint frontend 

React Hook "useLocale" is called in function "cell" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter. React Hook names must start with the word "use"

const renderedCell = renderCellValue({
column,
Expand Down Expand Up @@ -554,7 +554,7 @@
if (typeof value === "number") {
return (
<div onClick={selectCell} className={cellStyles}>
<LocaleNumber value={value} maxDisplayPrecision={maxDisplayPrecision}/>
<LocaleNumber value={value} maxDisplayPrecision={maxDisplayPrecision} />
</div>
);
}
Expand Down Expand Up @@ -600,7 +600,15 @@
);
}

const LocaleNumber = ({ value, maxDisplayPrecision }: { value: number, maxDisplayPrecision: number }) => {
const format = useNumberFormatter({ maximumFractionDigits: maxDisplayPrecision });
const LocaleNumber = ({
value,
maxDisplayPrecision,
}: {
value: number;
maxDisplayPrecision: number;
}) => {
const format = useNumberFormatter({
maximumFractionDigits: maxDisplayPrecision,
});
return format.format(value);
};
Loading