simplify edit notebook tool and add google tool schema cleanup #7228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Light2Dark
force-pushed
the
sham/simplify-edit-notebook-tool
branch
from
2ca82a1 to
74ee2aa
Compare
mscolnick
reviewed
Nov 21, 2025
| "properties": tool.parameters.get("properties", {}), | ||
| "required": tool.parameters.get("required", []), | ||
| }, | ||
| "parameters": _clean_google_parameters( |
Contributor
There was a problem hiding this comment.
it would be great to enforce this at build/test time instead of at runtime
Contributor
Author
There was a problem hiding this comment.
Yeah.., because it's a frontend tool, I'm not sure how we can test the zod schema against this. Do you have ideas?
Another option is to review the source code for gemini tools to only include allowed keys.
edit: I can check this
mscolnick
previously approved these changes
Nov 21, 2025
## 📝 Summary <!-- Provide a concise summary of what this pull request is addressing. If this PR fixes any issues, list them here by number (e.g., Fixes #123). --> ## 🔍 Description of Changes <!-- Detail the specific changes made in this pull request. Explain the problem addressed and how it was resolved. If applicable, provide before and after comparisons, screenshots, or any relevant details to help reviewers understand the changes easily. --> ## 📋 Checklist - [x] I have read the [contributor guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md). - [ ] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on [Discord](https://marimo.io/discord?ref=pr), or the community [discussions](https://github.com/marimo-team/marimo/discussions) (Please provide a link if applicable). - [x] I have added tests for the changes made. - [x] I have run the code and verified that it works as expected.
mscolnick
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
The motivation to clean up the edit notebook tool is that discriminated unions are more verbose in context size:
tool schema parameters with discriminated union
after simplifying
However, the google tools spec is still quite restrictive, even with the cleaned up edit notebook tool. So I implemented a thin wrapper inspired by #7211 on the backend to make sure schemas are compliant.
🔍 Description of Changes
📋 Checklist