Skip to content

pandas change to to_dict instead of to_json and fix rich elems #7223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 24, 2025
Merged

pandas change to to_dict instead of to_json and fix rich elems #7223

merged 8 commits into from
Nov 24, 2025

Conversation

@Light2Dark
Copy link
Contributor

@Light2Dark Light2Dark commented Nov 20, 2025 •
edited
Loading

📝 Summary

to_dict is closer to the raw values returned by pandas. For example, the different versions of nulls below would return empty previously. Now they return values.

Screenshot 2025-11-20 at 6 06 31 PM

also changes to time periods

before:
Screenshot 2025-11-20 at 6 08 37 PM

after:
Screenshot 2025-11-25 at 2 07 13 AM

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.
@vercel
Copy link

vercel bot commented Nov 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Nov 24, 2025 5:36pm
@Light2Dark Light2Dark added bash-focus Area to focus on during release bug bash enhancement New feature or request labels Nov 20, 2025
@Light2Dark Light2Dark marked this pull request as draft November 20, 2025 14:38
@Light2Dark Light2Dark marked this pull request as ready for review November 21, 2025 17:02
@mscolnick
Copy link
Contributor

mscolnick commented Nov 21, 2025

are images and UI elements unchanged? if not, may need to update inside marimo/_messaging/msgspec_encoder.py
mscolnick
mscolnick previously approved these changes Nov 21, 2025
View reviewed changes
@Light2Dark Light2Dark force-pushed the sham/pandas-change-to-dict branch from c881d5f to a92f07e Compare November 24, 2025 08:39
@Light2Dark Light2Dark changed the title pandas change to to_dict instead of to_json Nov 24, 2025
@Light2Dark Light2Dark merged commit c8d9421 into main Nov 24, 2025
31 of 59 checks passed
@Light2Dark Light2Dark deleted the sham/pandas-change-to-dict branch November 24, 2025 19:07
@Light2Dark Light2Dark mentioned this pull request Nov 25, 2025
Closed
1 task
@mscolnick mscolnick mentioned this pull request Nov 25, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bash-focus Area to focus on during release bug bash enhancement New feature or request

3 participants

@Light2Dark @mscolnick