Skip to content

Show api key only on the creation #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 19, 2025
Merged

Show api key only on the creation #1642

merged 3 commits into from
Apr 19, 2025

Conversation

dragonpoo
Copy link
Collaborator

Proposed changes

Show api key only on the creation

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

@dragonpoo dragonpoo requested a review from ludomikula April 16, 2025 19:07
Copy link

netlify bot commented Apr 16, 2025

Deploy Preview for lowcoder-test canceled.

Name Link
🔨 Latest commit 5bdedc9
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-test/deploys/6803a0e122d4960008b15336
Adding support for more RAM for the sonar check server
FalkWolsky
FalkWolsky previously approved these changes Apr 19, 2025
Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the change! It is a truly important security optimization

Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@FalkWolsky FalkWolsky merged commit 41e2af2 into dev Apr 19, 2025
6 checks passed
@FalkWolsky FalkWolsky deleted the hide_api_key branch April 19, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants