Overrides default Lua print with tracing alternative #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipharius
force-pushed
the
feature/lua-print-tracing
branch
from
d2a4ea7 to
e8b805b
Compare
Contributor
Author
|
The empty print case is still not satisfactory, will fix it first. |
cipharius
force-pushed
the
feature/lua-print-tracing
branch
from
e8b805b to
71c35bc
Compare
Contributor
Author
|
No more dancing around fixed, mutable string prefix. Now works well |
letoram
requested changes
Sep 16, 2023
Owner
letoram
left a comment
letoram
left a comment
There was a problem hiding this comment.
this is a better fit in src/engine/alt/trace.c as _lua.c will slowly be split out into that.
cipharius
force-pushed
the
feature/lua-print-tracing
branch
from
71c35bc to
e815573
Compare
cipharius
force-pushed
the
feature/lua-print-tracing
branch
from
e815573 to
8c7ffc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In attempt to improve the appl debugging sittuation, this provides custom Lua print function and augments it with tracing support.