feat: eta-expand recursor major for subsingleton structures - #15371
Draft
arthur-adjedj wants to merge 2 commits into
Draft
arthur-adjedj wants to merge 2 commits into
arthur-adjedj wants to merge 2 commits into
Conversation
5 tasks
github-actions
Bot
added
the
toolchain-available
Contributor
Author
|
downstream |
downstream-lean4
Bot
added
the
downstream
|
The adaptation PR for this PR is leanprover/downstream-lean4#115. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR expands the condition for which the major of a recursor can be eta-expanded. Namely, subsingleton structures such as
Andshould be eta-expanded in this situation.This PR depends on #15351 to make sure the non-termination of proof normalization doesn't leak to non-proof terms (see test file for example)
TODO more tests
Related to #14977
Closes #3213