Skip to content

Conversation

@douxc
Copy link
Contributor

@douxc douxc commented Dec 5, 2025

  • Remove duplicate slash between basePath and WBB_APP_LOGIN_PATH
  • Prevents double slashes in redirect URL

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
- Remove duplicate slash between basePath and WBB_APP_LOGIN_PATH
- Prevents double slashes in redirect URL
Copilot AI review requested due to automatic review settings December 5, 2025 01:48
@douxc douxc requested a review from iamjoel as a code owner December 5, 2025 01:48
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 5, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @douxc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a minor but important bug in the web application's URL construction logic. It specifically targets the login redirect URL, where a redundant slash was being introduced between the base path and the login path. By removing this extra slash, the PR ensures that all generated redirect URLs are correctly formatted, preventing potential issues with navigation or routing and improving the overall robustness of the application's URL handling.

Highlights

  • Redirect URL Fix: Corrected an issue where the web application's login redirect URL contained a duplicated slash.
  • Path Concatenation: The redundant slash was removed from the concatenation of basePath and WBB_APP_LOGIN_PATH.
  • URL Consistency: Ensures that the generated login redirect URLs are correctly formed without unintended double slashes, improving navigation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue with duplicated slashes in the web app redirect URL. The change correctly removes an extra slash when constructing the URL, which resolves the problem in most scenarios. I've added a suggestion to make the fix more robust by handling cases where basePath might be configured with a trailing slash.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a URL construction bug that created duplicate slashes in the webapp SSO login redirect URL. The issue occurred when concatenating basePath with WBB_APP_LOGIN_PATH, where both the concatenation operator and the path constant included a forward slash.

  • Removed duplicate slash between basePath and WBB_APP_LOGIN_PATH in redirect URL construction
  • Aligns with the consistent URL construction pattern used throughout the codebase
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 5, 2025
@douxc douxc merged commit 7f5fda9 into main Dec 5, 2025
19 checks passed
@douxc douxc deleted the fix/webapp-duplicate-slash branch December 5, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

3 participants