-
Notifications
You must be signed in to change notification settings - Fork 19.3k
fix: remove duplicated slash in webapp redirect_url #29161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Remove duplicate slash between basePath and WBB_APP_LOGIN_PATH - Prevents double slashes in redirect URL
Summary of ChangesHello @douxc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a minor but important bug in the web application's URL construction logic. It specifically targets the login redirect URL, where a redundant slash was being introduced between the base path and the login path. By removing this extra slash, the PR ensures that all generated redirect URLs are correctly formatted, preventing potential issues with navigation or routing and improving the overall robustness of the application's URL handling. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses an issue with duplicated slashes in the web app redirect URL. The change correctly removes an extra slash when constructing the URL, which resolves the problem in most scenarios. I've added a suggestion to make the fix more robust by handling cases where basePath might be configured with a trailing slash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a URL construction bug that created duplicate slashes in the webapp SSO login redirect URL. The issue occurred when concatenating basePath with WBB_APP_LOGIN_PATH, where both the concatenation operator and the path constant included a forward slash.
- Removed duplicate slash between
basePathandWBB_APP_LOGIN_PATHin redirect URL construction - Aligns with the consistent URL construction pattern used throughout the codebase
Important
Fixes #<issue number>.Summary
Screenshots
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods