Skip to content

community[patch]: Fix bug in Neo4j new enhancedSchema flag #5622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2024
Merged

community[patch]: Fix bug in Neo4j new enhancedSchema flag #5622

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions libs/langchain-community/src/graphs/neo4j_graph.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,20 +188,24 @@ function formatSchema(
}
} else {
// Format node properties
formattedNodeProps = schema.nodeProps.map((el: Record<string, Any>) => {
const propsStr = el.properties
.map((prop: Record<string, Any>) => `${prop.property}: ${prop.type} `)
.join(", ");
return `${el.labels} {${propsStr} } `;
});
formattedNodeProps = Object.entries(schema.nodeProps).map(
([key, value]: [string, Any]) => {
const propsStr = value
.map((prop: Record<string, Any>) => `${prop.property}: ${prop.type}`)
.join(", ");
return `${key} {${propsStr}}`;
}
);

// Format relationship properties
formattedRelProps = schema.relProps.map((el: Record<string, Any>) => {
const propsStr = el.properties
.map((prop: Record<string, Any>) => `${prop.property}: ${prop.type} `)
.join(", ");
return `${el.type} {${propsStr} } `;
});
formattedRelProps = Object.entries(schema.relProps).map(
([key, value]: [string, Any]) => {
const propsStr = value
.map((prop: Record<string, Any>) => `${prop.property}: ${prop.type} `)
.join(", ");
return `${key} {${propsStr} } `;
Copy link
Collaborator

@jacoblee93 jacoblee93 May 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the extra space here a mistake?

Not a regression so won't block on it
}
);
}

// Format relationships
Expand Down