Skip to content

google-genai [patch]: set apiVersion #5480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

google-genai [patch]: set apiVersion #5480

wants to merge 1 commit into from

Conversation

@stuntnmore
Copy link

@stuntnmore stuntnmore commented May 20, 2024 •
edited
Loading

Fixes # (issue)
add setting api version on google gen ai, so it can support v1 or v1beta which has more models available
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 20, 2024
@vercel
Copy link

vercel bot commented May 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 2:54pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview May 20, 2024 2:54pm
@stuntnmore stuntnmore mentioned this pull request May 20, 2024
Closed
5 tasks
@afirstenberg
Copy link
Contributor

afirstenberg commented May 20, 2024

@stuntnmore - I can't do this, but I suggest changing the name to something like:
google-genai [patch]: set apiVersion
@afirstenberg
Copy link
Contributor

afirstenberg commented May 20, 2024 •
edited
Loading

Yeah, it looks like #5426 added the apiVesion field, and then set it to "v1" by default which blocked the new models. Which undid what #5115 did (which was to use the latest version of the library, which used "v1beta" by default.) (And where I requested we add the "apiVersion", but we were in a rush to get it out.)

LGTM
@stuntnmore stuntnmore changed the title add support to set apiVersion in fields so more models can be supported May 20, 2024
@stuntnmore
Copy link
Author

stuntnmore commented May 20, 2024 •
edited
Loading

@stuntnmore - I can't do this, but I suggest changing the name to something like: google-genai [patch]: set apiVersion

name changed :)
@bracesproul
Copy link
Member

bracesproul commented May 20, 2024

Hey, I'm going to close this in favor of #5490 which uses the fields passed into the constructor, and removes the class properties since they weren't being used outside of the constructor.
@stuntnmore stuntnmore deleted the add/genaiApiVersioning branch May 20, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

3 participants

@stuntnmore @afirstenberg @bracesproul