Skip to content

Conversation

@dishaprakash
Copy link
Collaborator

chore(docs): Add an Async Explainer doc

This async explainer doc explains the benefits of a having duality in classes for PGVectorStore.

@dishaprakash dishaprakash marked this pull request as draft April 14, 2025 10:19
@averikitsch
Copy link
Collaborator

@eyurtsev what are your thoughts on adding this as a GitHub wiki for this repo?

@eyurtsev
Copy link
Collaborator

@eyurtsev what are your thoughts on adding this as a GitHub wiki for this repo?

We tend to use mkdocs since it's visually more appealing, but it has slightly higher overhead, so entirely up to you!

@dishaprakash dishaprakash marked this pull request as ready for review April 17, 2025 21:24
@averikitsch
Copy link
Collaborator

@eyurtsev what are your thoughts on adding this as a GitHub wiki for this repo?

We tend to use mkdocs since it's visually more appealing, but it has slightly higher overhead, so entirely up to you!

@eyurtsev Do you have any concerns with having this doc in the root of the repo or would you like us to create a docs/ directory?

@eyurtsev
Copy link
Collaborator

Docs folder is better

@dishaprakash dishaprakash requested a review from eyurtsev April 22, 2025 18:25
@dishaprakash dishaprakash merged commit fe8b622 into main Apr 30, 2025
5 checks passed
@dishaprakash dishaprakash deleted the dishaprakash-patch-1 branch April 30, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants