ambiguous overloads with Span function parameters #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* to prevent ambiguities during overload resolution * to disable the constructor if the source's value type is incompatible
Owner
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started out trying to fix #22 and noticed there are also other, undesirable conversions that are currently allowed (see #23).
This PR is my attempt at fixing both,
by adding SFINAE constraints (and a few non-template iterator/pointer overloads) to the constructors.
I also added these constraints to the try_init factory functions where applicable,
though they could conceivably be replaced with static_asserts there.
I tried to keep the formatting consistent when I had to spread the enable_if conditions over multiple lines,
I'm not sure if I succeeded everywhere.