Skip to content

Conversation

@JoshuaWatt
Copy link
Contributor

Adds support for the helper.yaml file to specify which subcommands users are allowed to execute using labgrid-raw-interface. Denied commands will fail with an error.

The RawNetworkInterfaceDriver is updated to query if the ip command is allowed before attemping to bring the interface up and down on activate/deactivate. This prevents it from erroring out if this behavior is not allowed

Description

Checklist

  • Documentation for the feature
  • Tests for the feature
  • The arguments and description in doc/configuration.rst have been updated
  • Add a section on how to use the feature to doc/usage.rst
  • Add a section on how to use the feature to doc/development.rst
  • PR has been tested
  • Man pages have been regenerated
Adds support for the helper.yaml file to specify which subcommands
users are allowed to execute using labgrid-raw-interface. Denied
commands will fail with an error.

The RawNetworkInterfaceDriver is updated to query if the `ip` command is
allowed before attemping to bring the interface up and down on
activate/deactivate. This prevents it from erroring out if this behavior
is not allowed

Signed-off-by: Joshua Watt <Joshua.Watt@garmin.com>
@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.1%. Comparing base (2be282f) to head (3b71b31).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
labgrid/driver/rawnetworkinterfacedriver.py 0.0% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1808     +/-   ##
========================================
- Coverage    45.1%   45.1%   -0.1%     
========================================
  Files         172     172             
  Lines       13617   13619      +2     
========================================
  Hits         6143    6143             
- Misses       7474    7476      +2     
Flag Coverage Δ
3.10 45.1% <0.0%> (-0.1%) ⬇️
3.11 45.1% <0.0%> (-0.1%) ⬇️
3.12 45.1% <0.0%> (-0.1%) ⬇️
3.13 45.0% <0.0%> (-0.1%) ⬇️
3.14 45.0% <0.0%> (-0.1%) ⬇️
3.9 45.1% <0.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant