Fix lint #1418
Open
Fix lint #1418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,6 +16,7 @@ all: clean install | |||
| cp -r ./app/dist ./server/build/public | |||
|
|
|||
| install: | |||
| ${YARN} | |||
There was a problem hiding this comment.
Suggested change
| ${YARN} | |
| $(YARN) |
There was a problem hiding this comment.
Let's also add rm -rf ./node_modules to clean
|
Let's separate lint setup commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes in detail.
Related Issue
If suggesting a new feature or change, please discuss it in an issue first. _If fixing a bug, there should be an issue describing it with steps to reproduce. Please link to any related issues here:
Motivation and Context
Why is this change required? What problem does it solve?
How Has This Been Tested?
Please describe in detail how you tested your changes. Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc.
Types of Changes
Screenshots (if appropriate):