fix: v0.7.1 hotfix - Issues #15, #16, #17 #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace hardcoded Version constant with dynamic injection: - Change const to var with 'dev' default for local development - Add GetVersion() with fallback to runtime/debug.ReadBuildInfo() - Update .goreleaser.yml to inject version into runtime package - Add -trimpath and mod_timestamp for reproducible builds This fixes issue #15 (missing go.sum) and #17 (wrong version in stack traces) where v0.4.10 was hardcoded instead of current release version. Version priority: 1. ldflags (GoReleaser builds) 2. Build info (go install @Version) 3. 'dev' fallback (local development) Fixes: #15, #17
Add CGO detection and handling: - Add isCGOFile() to detect 'import "C"' in AST - Add CGOSkipped flag to InstrumentStats - Copy CGO files unchanged instead of instrumenting - Print 'Skipped (CGO): filename' for visibility CGO files cannot be processed by go/parser for C symbols. This fixes compilation errors like: could not determine what C.xxx refers to Fixes: #16
- Use stored PC directly instead of capturing current stack - Remove misleading 'future enhancement' message - Clarify that PC points to OnWrite/OnRead (internal frame) Note: Full stack traces for previous access require storing multiple PCs in VarState, planned for v0.8.0. Partial fix for: #17
Test command fixes (Issue #15): - Add -c flag support (compile only, don't run) - Add -o flag support (output file path) - Copy compiled binary to specified output path - Add copyFile() helper for cross-platform support Stack trace improvements (Issue #17): - captureCallerPC() now captures user-code PC correctly (skip=2) - formatStackTrace() filters internal frames (OnWrite, OnRead, runtime.*) - Fallback shows internal frame if it's all we have (better than nothing) - Extract isInternalStackFrame() and writeFrameToBuffer() helpers - Reduce cyclomatic complexity from 17 to acceptable levels Performance note: - PC capture ~145ns (runtime.Callers baseline on Windows Go 1.25.3) - Within <20x overhead target, optimization tracked in Issue #18 Fixes: #15, #17
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
- Coverage 73.55% 72.68% -0.88%
==========================================
Files 26 26
Lines 2583 2658 +75
==========================================
+ Hits 1900 1932 +32
- Misses 579 619 +40
- Partials 104 107 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hotfix release addressing bugs reported by @glycerine.
Fixes
Issue #15: Test command flags
-cflag support (compile only, don't run)-oflag support (output file path)Issue #16: CGO file handling
import "C"statementIssue #17: Stack traces
captureCallerPC()now captures user-code PC correctlyformatStackTrace()filters internal frames (OnWrite, OnRead, runtime.*)Test plan
racedetector test -c -oworks correctlyRelated