Skip to content

Conversation

@kirillzyusko
Copy link
Owner

@kirillzyusko kirillzyusko commented Dec 1, 2025

📜 Description

Updated jsdoc and type declaration for dismiss method.

💡 Motivation and Context

The options object serves asa configuration object. We may skip some properties and it should use default options then. In fact our implementation already has correct options:

const dismiss = async (options?: Partial<DismissOptions>): Promise<void> => {

So in this PR I just reflected it in types 🙃

📢 Changelog

JS

  • changed JSDoc of dismiss method;
  • marked options as Partial in types declaration file.

🤔 How Has This Been Tested?

Tested in example project.

📸 Screenshots (if appropriate):

Before After
Screenshot 2025-12-01 at 10 13 27 image

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed
@kirillzyusko kirillzyusko self-assigned this Dec 1, 2025
@kirillzyusko kirillzyusko added the 🐛 bug Something isn't working label Dec 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

📊 Package size report

Current size Target Size Difference
230139 bytes 230076 bytes 63 bytes 📈
@kirillzyusko kirillzyusko marked this pull request as ready for review December 1, 2025 09:16
@kirillzyusko kirillzyusko merged commit 4bdf4e5 into main Dec 1, 2025
11 of 23 checks passed
@kirillzyusko kirillzyusko deleted the fix/dismiss-method-types-mismatch branch December 1, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working

2 participants