fix: types mismatch for dismiss method
#1225
Merged
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Updated jsdoc and type declaration for
dismissmethod.💡 Motivation and Context
The
optionsobject serves asa configuration object. We may skip some properties and it should use default options then. In fact our implementation already has correct options:So in this PR I just reflected it in types 🙃
📢 Changelog
JS
dismissmethod;Partialintypesdeclaration file.🤔 How Has This Been Tested?
Tested in example project.
📸 Screenshots (if appropriate):
📝 Checklist