Tests: Fix selector tests in Chrome 141 #5716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
added
Needs review
Tests
Discuss in Meeting
timmywil
approved these changes
Oct 27, 2025
timmywil
removed
Needs review
Discuss in Meeting
Chrome 141 incorrectly matches `:lang()` selectors with values with a trailing `-`. This is fixed in Chrome 142, so just skip these tests in v141. See https://issues.chromium.org/issues/451355198
mgol
force-pushed
the
chrome-141-test-exclusions
branch
from
676c8b2 to
430b5d9
Compare
Member
Author
|
Chrome 142 stable is out (more precisely, on macOS it's 142.0.7444.60) and it contains the fix, so excluding v141 will be enough. Merging! |
mgol
added a commit
that referenced
this pull request
Oct 28, 2025
Chrome 141 incorrectly matches `:lang()` selectors with values with a trailing `-`. This is fixed in Chrome 142, so just skip these tests in v141. See https://issues.chromium.org/issues/451355198 Closes gh-5717 Ref gh-5716
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Chrome 141 incorrectly matches
:lang()selectors with values with a trailing-. This is fixed in Chrome 142, so just skip these tests in v141. See https://issues.chromium.org/issues/451355198mainversion of #5717Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com