Update tensorflow and xprof constraints in collect-profile-requiremen… - #40299
Merged
Conversation
…ts.txt - Update tensorflow constraint from <3.13 to <3.14 now that 3.13 wheels are available. - Guard xprof with python_version < 3.15 to avoid pulling in cryptography on Python 3.15t where wheels are not yet available.
copybara-service Bot
pushed a commit
that referenced
this pull request
Aug 28, 2026
**Why?** program_order(enforce=True) traverses the jaxpr and adds opt_barrier of the form `opt_barrier((prev_outs, cur_inputs))`. It does not recurse into HOPs though. One consequence of adding opt_barriers (other than disallowing all kinds of optimizations) is that it also alters the lifetime of some arrays (I'll give an example below). So what `exclude_argnames` on `program_order(enforce=False)` does is it allows us to skip some `cur_inps` from the `opt_barrier((prev_outs, cur_inps))`. This opt_barrier is inserted by an outer program_order(enforce=True), so `enforce=False` is nested. Note that exclude_argnames only works when `enforce=False`. Also, if some arrays are closed over, then those can't be excluded. To exclude, arrays should be inputs and added to `exclude_argnames` (maybe we can support closed over inputs somehow but not today). To make this work, we added a `program_order` primitive but it's very lightweight since it piggybacks on `eval_jaxpr_p`! **Example of opt_barrier altering lifetimes** ``` x, y = opt_barrier((x, y) # Will force both x and y to be ready here! f(x) g(y) ``` Without the opt_barrier: ``` f(x) # x can be ready here g(y) # y can be ready here ``` FUTURE_COPYBARA_INTEGRATE_REVIEW=#40299 from hawkinsp:deps 067ddf0 PiperOrigin-RevId: 972232723
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nts.txt