Skip to content

WebSocket 2.2.0 release #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 22, 2024
Merged

Conversation

markt-asf
Copy link
Contributor

@markt-asf markt-asf commented Mar 25, 2024

Specification PR template

When creating a specification project release review, create PRs with the content defined as follows.

Include the following in the PR:

Note: If any item does not apply, check it and mark N/A below it.

@markt-asf
Copy link
Contributor Author

I'm expecting to fill in the blanks over the next 24 hours or so.

Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for jakartaee-specifications ready!

Name Link
🔨 Latest commit 0f5d948
🔍 Latest deploy log https://app.netlify.com/sites/jakartaee-specifications/deploys/6601c6b5eb44dc0008eee488
😎 Deploy Preview https://deploy-preview-713--jakartaee-specifications.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for jakartaee-specifications ready!

Name Link
🔨 Latest commit 5be9dc8
🔍 Latest deploy log https://app.netlify.com/sites/jakartaee-specifications/deploys/663b6c44f959e20008989e2e
😎 Deploy Preview https://deploy-preview-713--jakartaee-specifications.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kazumura
Copy link
Contributor

kazumura commented Mar 26, 2024

Spec Review Checklist

  1. Spec PR
  1. _index.md
  1. javadocs
  • Footer contains Eclipse copyright and link to license
  • ESFL license is included, usually as doc-files/speclicense.html
  • no META-INF directory in PR
  • javadocs-jar artifact matches apidocs (optional for this release)
  1. Spec PDF
  • Correct spec title
  • Version number of the form x.y, not x.y.z
  • Correct Eclipse copyright line
  • No DRAFT or SNAPSHOT
  • Correct Logo
  1. Spec HTML
  • Same as PDF
  1. TCK zip file
  • README file (optional for this release)
  • EFTL license file, preferably named LICENSE.md
  • User's Guide (or equivalent documentation)
  • How to test the Compatible Implementation(s) listed in _index.md above with the TCK (may be in UG)
  1. TCK User's Guide (or equivalent documentation)
  • Software requirements listed
  • Installation and configuration described
  • How to run tests
  • Where to file challenges
  1. Compatibility certification request
  • Request follows template
  • SHA-256 fingerprint matches staged TCK zip file
  • Request issue has certification label.
  1. TCK results summary
  • Page is hosted by Compatible Implementation project
  • Includes all information from certification request
  • Summary includes number of tests passed, failed, errors
  • SHA-256 fingerprint matches staged TCK zip file on cert request
  1. If a Release Review is required, the specification project team contacts the EMO to initiate the review by sending an email to emo@eclipse.org.
    (A Release Review is not required if the current release is a Service Release based on a previously successful Major or Minor
    release as indicated by a release record on the project's Releases page, e.g., the Jakarta Servlet releases page.)

  2. Update Jakarta EE API jar

  • Update the Jakarta EE API jar by submitting a PR to the jakartaee-api project that updates the version number of your API jar file.
@ivargrimstad ivargrimstad added the release review Use this label on PRs that are filed for release review label Mar 26, 2024
Copy link
Contributor

@kazumura kazumura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markt-asf Thanks fro PR.

  • The name of specification documentation must be
    "jakarta-websocket-spec-2.2.{html|pdf}" but not "websocket-spec-2.2.{html|pdf}".

  • Do not include META-INF directories in the PR.

  • Copyright years in API doc footer must be "2018, 2024", but not "2018, 2022".

  • Use v1.1 of EFSL but not v1.0. (in specification documents and api doc)

  • Do not modify the text of EFSL. (you do not need to change place holders)
    For reference see "https://www.eclipse.org/lists/jakarta.ee-wg/msg00996.html".

  • Include v1.1 of Technology Compatibility Kit License v but not v1.0. (LICENSE.md in TCK zip file)

  • In README.txt in TCK zip file,
    "2. Download and install the WebSocket 2.1 Compatible Implementation/jarfile." must be "... WebSocket 2.2 ...".

@markt-asf
Copy link
Contributor Author

I've fixed the non-TCK issues, restaged the 2.2.0 release and updated this PR.
I have created jakartaee/platform-tck#1271 for the TCK issues although I'm not sure how to address the TCK license issue.

@markt-asf
Copy link
Contributor Author

All the required material should now be available.
Note that the certification request is for a 11.0.0-M19-SNAPSHOT release of Tomcat. I expect to update this to the 11.0.0-M19 release once that is available early/mid in April.

@markt-asf markt-asf marked this pull request as ready for review March 27, 2024 16:56
@kazumura
Copy link
Contributor

@markt-asf Thanks for updating.

@markt-asf
Copy link
Contributor Author

EFSL for Javadoc updated and WebSocket 2.2 restaged to pick up that change.
Javadoc copy and staging repo link updated.
Label added to certification request

@kazumura kazumura added final Ready for Vote ballot Delivered to the Specification Committee for ballot labels Mar 29, 2024
@markt-asf
Copy link
Contributor Author

Note: The TCK being used still has SNAPSHOT dependencies. This review should not progress until an updated TCK is available without SNAPSHOT dependencies.

@mtdelgadoa
Copy link

mtdelgadoa commented Apr 9, 2024

Hello all,
the EMO is trying to avoid duplication of release records, so we will be providing our feedback and comments related to this release directly here.

EDP Review status: COMPLETED

EMO review checklist

PMI record: https://projects.eclipse.org/projects/ee4j.websocket/reviews/2.2.0-release-review

EF Specification Process

  • Spec Committee Ballot completed

Intellectual Property Management

  • All project code has copyright and license headers correctly applied. ** EMO will scan the code at their discretion **
  • All distributed third-party content has been vetted by the IP Due Diligence process (i.e., IP Log has been approved)

Open Source Rules of Engagement

General:

  • Project is operating within the mission and scope defined in its top-level project’s charter
  • Project is operating within the bounds of its own scope
  • Project is operating in an open and transparent manner
  • Overall the project is operating according to the Eclipse Development Process.

Things to check:

  • Communication channels advertised
  • Advertised communication channels used
  • Committers are responding to questions
  • Committers are responding to issues
  • Committers are responding to pull/merge/review requests

Branding and Trademarks
The following applies when the project has a custom website.
To the best of our knowledge:

  • Project content correctly uses Eclipse Foundation trademarks
  • Project content (code and documentation) does not violate trademarks owned by other organizations

Things to check:

  • Project website uses the project's formal name in first and all prominent references
  • Project website includes a trademark attribution statement
  • Project website footers contain all necessary elements

Legal Documentation
Required files:

  • License files in all repository roots
  • README
  • CONTRIBUTING (or equivalent)

Recommended files:

See examples for Security file and Code of Conduct.

Required elements:

  • ECA is referenced/described

Recommended elements:

Metadata (PMI)

  • The formal name, e.g. "Eclipse Foo™", is used in the project title
  • The formal name including appropriate marks (e.g, "™") is used in the first mention in the text of the project description, and scope
  • The project description starts with a single paragraph that can serve as an executive summary
  • Source code repository references are up-to-date
  • Download links and information are up-to-date (see EF handbook for more information on how-to do this)
  • Communication channels listed in the PMI (i.e. public mailing list, forums, etc.)
@kazumura
Copy link
Contributor

@markt-asf

Note: The TCK being used still has SNAPSHOT dependencies. This review should not progress until an updated TCK is available without SNAPSHOT dependencies.

I withdraw the current ballot.
I will restart the ballot after TCK and CCR will be updated.

@kazumura kazumura removed the ballot Delivered to the Specification Committee for ballot label Apr 14, 2024
@Emily-Jiang
Copy link
Contributor

@markt-asf can you look into the issues raised by @kazumura so that the release ballot can be started?

While, strictly, no references were removed, a reference was added in
the 2.1.1 release so - effectively - that was removed for 2.2.0.
@markt-asf
Copy link
Contributor Author

I believe the issues have all been resolved and the release ballot can be started.

@kazumura kazumura added the ballot Delivered to the Specification Committee for ballot label May 14, 2024
@kazumura kazumura added approved The ballot was approved by the Specification Committee and removed ballot Delivered to the Specification Committee for ballot labels May 21, 2024
@kazumura
Copy link
Contributor

@kazumura kazumura merged commit 3257336 into jakartaee:master May 22, 2024
5 checks passed
@kazumura
Copy link
Contributor

kazumura commented May 22, 2024

On ballot completion, the specification committee mentor:

  • adds this final checklist to the main PR.
  • adds the approved label to the PRs, and sends out the Ballot Summary per this template to the public Jakarta EE Specification Committee email list
  • calculates the staged EFTL TCK signature and promotes it to the committee download area
    using the https://ci.eclipse.org/jakartaee-spec-committee/job/promote-release/ job. Manually editing the jenkins Build Information will help identify the build (ie. Mail 2.0 or CDI 3.0).
  • merges the specification (and apidocs) PRs, ensuring the "date:" field in the _index.md file has an appropriate value to allow publishing.
  • updates the specification page with the ballot results. This is normally done via a separate PR that should be reviewed, approved, and merged.
  • notifies the EMO of the ballot results by email to emo@eclipse-foundation.org. Just forward the ballot summary note sent earlier to the public Spec Committee email list.
  • creates an issue in the specification project that includes the following checklist for the specification project team:
    Finalize the Jakarta Websocket 2.2 Release websocket#428
@markt-asf markt-asf deleted the release-websocket-2.2 branch March 21, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved The ballot was approved by the Specification Committee final Ready for Vote release review Use this label on PRs that are filed for release review
6 participants