-
Notifications
You must be signed in to change notification settings - Fork 90
WebSocket 2.2.0 release #713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm expecting to fill in the blanks over the next 24 hours or so. |
✅ Deploy Preview for jakartaee-specifications ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for jakartaee-specifications ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Spec Review Checklist
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markt-asf Thanks fro PR.
-
The name of specification documentation must be
"jakarta-websocket-spec-2.2.{html|pdf}" but not "websocket-spec-2.2.{html|pdf}". -
Do not include META-INF directories in the PR.
-
Copyright years in API doc footer must be "2018, 2024", but not "2018, 2022".
-
Use v1.1 of EFSL but not v1.0. (in specification documents and api doc)
-
Do not modify the text of EFSL. (you do not need to change place holders)
For reference see "https://www.eclipse.org/lists/jakarta.ee-wg/msg00996.html". -
Include v1.1 of Technology Compatibility Kit License v but not v1.0. (LICENSE.md in TCK zip file)
-
In README.txt in TCK zip file,
"2. Download and install the WebSocket 2.1 Compatible Implementation/jarfile." must be "... WebSocket 2.2 ...".
I've fixed the non-TCK issues, restaged the 2.2.0 release and updated this PR. |
All the required material should now be available. |
@markt-asf Thanks for updating.
|
EFSL for Javadoc updated and WebSocket 2.2 restaged to pick up that change. |
Note: The TCK being used still has SNAPSHOT dependencies. This review should not progress until an updated TCK is available without SNAPSHOT dependencies. |
Hello all, EDP Review status: COMPLETED EMO review checklistPMI record: https://projects.eclipse.org/projects/ee4j.websocket/reviews/2.2.0-release-review EF Specification Process
Intellectual Property Management
Open Source Rules of Engagement
General:
Things to check:
Branding and Trademarks
Things to check:
Legal Documentation
Recommended files:
See examples for Security file and Code of Conduct. Required elements:
Recommended elements:
Metadata (PMI)
|
I withdraw the current ballot. |
@markt-asf can you look into the issues raised by @kazumura so that the release ballot can be started? |
While, strictly, no references were removed, a reference was added in the 2.1.1 release so - effectively - that was removed for 2.2.0.
I believe the issues have all been resolved and the release ballot can be started. |
ballot completed. |
On ballot completion, the specification committee mentor:
|
Specification PR template
When creating a specification project release review, create PRs with the content defined as follows.
Include the following in the PR:
https://github.com/jakartaee/specification-committee/blob/master/spec_page_template.md
Instructions MAY be by reference.
[ ] Generated IP Logno longer required according to project handbookhttps://jakarta.oss.sonatype.org/content/repositories/jakartawebsocket-1026/
https://www.eclipse.org/downloads/download.php?file=/ee4j/jakartaee-tck/jakartaee11/staged/eftl/jakarta-websocket-tck-2.2.0.zip
Tomcat: Compatibility Certification Request for Tomcat 11.0.0-M20 websocket#427
Tyrus: Compatibility Certification Request for Eclipse Tyrus 2.2.0-M1 (JDK 21) websocket#425 and Compatibility Certification Request for Eclipse Tyrus 2.2.0-M1 (JDK 17) websocket#426
If desired, an optional second PR can be created to contain just the JavaDoc in the
apidocs
directory.Note: If any item does not apply, check it and mark N/A below it.