WIP - Card List #148
Open
WIP - Card List #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import React from 'react'; | ||
| import internal from 'stream'; | ||
| import { Customer } from '../generated'; | ||
| import SimpleCard from './Simplecard'; |
Contributor
There was a problem hiding this comment.
please, prefer named imports
| <Card className={classes.root}> | ||
| <CardContent> | ||
| <Typography variant="h5" component="h2"> | ||
| {customer_name} |
Contributor
There was a problem hiding this comment.
please check the issue there is title and subheader
Contributor
|
Nice start. Please continue with "write script that applies refactoring rules" (issue is referring to lowcode/packages/react-lowcode/src/codegen/generation/generators/template/template-resolver.ts) and do not forget to write jest test for your implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bugs that caused application to not work properly.