-
Notifications
You must be signed in to change notification settings - Fork 24
Switch CLI to use tyro
#578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
scottstanie
wants to merge
24
commits into
isce-framework:main
Choose a base branch
from
scottstanie:cli-tyro
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would you mind showing a screenshot of what the CLI looks like with tyro? |
![]() On the TODO list is switching the current ![]() |
This was referenced May 9, 2025
…ent short options Fixes the `TODO` printing from the comment adds a `Strides` class similar to the `HalfWindow` class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dolphin config
tool is both long (in the number of options you can specify) but also incomplete/out of date.This swtiches the cli to use
tyro
, allowing us to have a single source of truth for the large configuration options/ CLI functions with many arguments.While it adds a dependency, possibilities for making CLI tools to use
dolphin
areargparse
https://brentyi.github.io/tyro/#why-tyro gives a succinct summary of the benefits. I have found
tyro
to be the best implementation of all the attempts to "automate CLI tools from existing functions/objects".This will make addressing #361 #510 much simpler.