Skip to content
This repository was archived by the owner on Jul 20, 2024. It is now read-only.

Allow all ingress traffic #21

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Allow all ingress traffic #21

merged 1 commit into from
Jul 3, 2020

Conversation

thongdong7
Copy link
Contributor

To fix issue #20

@thongdong7 thongdong7 marked this pull request as ready for review June 30, 2020 04:31
@int128 int128 merged commit 97977ab into int128:master Jul 3, 2020
@int128
Copy link
Owner

int128 commented Jul 3, 2020

Thank you for your contribution!

@hcarver
Copy link

hcarver commented Jul 3, 2020

FYI @int128 this merge broke our use of this Terraform module; we were surprised by that too, given the nature of the change!

Error: Error revoking security group sg-<some code> rules: InvalidPermission.NotFound: The specified rule does not exist in this security group.

Manually editing the security group rules in the AWS console was not sufficient to fix it. After editing them to be for all protocols (not just TCP we saw this):

Error: [WARN] A duplicate Security Group rule was found on (sg-<some code>). This may be
a side effect of a now-fixed Terraform issue causing two security groups with
identical attributes but different source_security_group_ids to overwrite each
other in the state. See https://github.com/hashicorp/terraform/pull/2376 for more
information and instructions for recovery. Error message: the specified rule "peer: <some CIDR>, ALL, ALLOW" already exists

The fix for us was to delete the existing ingress rules, plan and apply. That's OK for us as our NAT is very low traffic, but this fix will not be palatable for all users!

@int128
Copy link
Owner

int128 commented Jul 3, 2020

@hcarver Thank you for pointing out the issue! I just released the fixed version.
Sorry I didn't test this PR on my environment actually.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
4 participants