fix: integrate docling as core dependency and standardize Python 3.12 #12342
+4,528
−3,538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses the docling installation issues reported in infiniflow#12187 by making docling a core dependency installed during image build rather than at runtime. Changes: - Add docling>=2.58.0 to pyproject.toml dependencies - Update Dockerfile to use Python 3.12 consistently (was 3.11) - Remove ensure_docling() runtime installation from entrypoint.sh - Remove USE_DOCLING environment variable from .env Benefits: - Fixes Python 3.12 pip/ensurepip missing module errors - Ensures torch is available for GPU-accelerated deepdoc processing - Simplifies deployment by eliminating conditional runtime installation - Maintains consistency with uv-based dependency management - Aligns with project's requires-python = ">=3.12,<3.15" specification Trade-offs: - Image size increases by ~2-3GB due to torch dependencies - Docling is now always included (no opt-out via USE_DOCLING) Fixes infiniflow#12187 Related to infiniflow#12317
dosubot
bot
added
the
size:S
Add build configuration to ragflow-cpu and ragflow-gpu services to enable local image building with the updated dependencies. This allows developers to build the image locally with the new docling dependency and Python 3.12 changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses the docling installation issues reported in #12187
by making docling a core dependency installed during image build rather than at runtime.
I realize we want to keep the images small, but without docling, all the cuda/torch/onnx stuff isn't installed either, which means Deepdoc and minerU can't use the GPU at all, although only docling is missing.
Changes:
Benefits:
Trade-offs:
Fixes #12187
Related to #12317
What problem does this PR solve?
Briefly describe what this PR aims to solve. Include background context that will help reviewers understand the purpose of the PR.
Type of change