Feat: Add replace_existing parameter to document upload API #12271
+85
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasumu
force-pushed
the
feature/replace-existing-on-upload
branch
from
d9e0b66 to
f4f25f9
Compare
dosubot
bot
added
size:M
Add optional replace_existing parameter to document upload endpoints.
When set to true, existing documents with the same name are deleted
before uploading, preventing duplicate filenames with (1), (2) suffixes.
- Add replace_existing parameter to FileService.upload_document()
- Delete storage file when replacing to prevent location collision
- Expose parameter in SDK API (POST /datasets/{id}/documents)
- Expose parameter in WebUI API (POST /upload)
- Add tests for replace_existing functionality
tasumu
force-pushed
the
feature/replace-existing-on-upload
branch
from
8a21de0 to
f7c01df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add optional replace_existing parameter to document upload endpoints. When set to true, existing documents with the same name are deleted before uploading, preventing duplicate filenames with (1), (2) suffixes.
What problem does this PR solve?
Motivation: We use a helper script to recursively upload only changed files from a directory to keep the RAG system up-to-date with the latest information.
Problem: When updating files, old versions are not deleted and new versions are added with names like
file(1).pdf. This causes:Solution: This PR adds a
replace_existingparameter that allows users to replace existing documents with the same name instead of creating duplicates.Type of change