Support huggingface_hub v0.x and v1.x #618
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
Author
|
@tomaarsen would you be able to review this PR please? CI gets a lot of errors but I hardly believe it's related to my changes. |
Member
|
Yes, will review. Thanks for opening this!
|
33 tasks
Contributor
Author
|
Gentle ping @tomaarsen about this PR (I just got a reminder about it^^). Currently SetFit is not compatible with huggingface_hub 1.x. For now 1.x usage is still a bit confidential since transformers v5.x has not yet been released but once it's done I expect much more users to migrate to it. Dunno how much usage SetFit is getting these days but let's try to minimize friction for when transformers v5 gets out :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to huggingface/huggingface_hub#3340.
This PR adapts SetFit to be compatible with both huggingface_hub v0.x and v1.x.
In practice nothing else should change (I've checked the codebase). The
HfHubHTTPErroris a base error defined inhuggingface_hubthat inherits fromrequests.HTTPErrorin v0.x and will inherit fromhttpx.HTTPErrorin v1.x. It has been introduced ~2 years ago so it's fine to use it right now (i.e. no need to wait for v1.x release or bump minimal version)