Skip to content

Conversation

@GCS-ZHN
Copy link

@GCS-ZHN GCS-ZHN commented Dec 31, 2024

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs
  • I have installed pre-commit: pip install pre-commit && pre-commit install

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

#6032

📝 What does this PR do?

Replace double quotation with single quotation to wrapper env variables during building launch command, to avoid some
special variables defined in users' client.

💥 Checklist before requesting a review

  • [x ] I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@GCS-ZHN GCS-ZHN requested a review from a team as a code owner December 31, 2024 10:04
@GCS-ZHN GCS-ZHN changed the title [fix] error on special env variables (#6032) Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant