fix(user): prevent NoneType error when additional_configs_urls is empty - #29
Open
aliwwwmo wants to merge 1 commit into
Open
fix(user): prevent NoneType error when additional_configs_urls is empty#29aliwwwmo wants to merge 1 commit into
aliwwwmo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a
500 Internal Server Error(specifically'NoneType' object has no attribute 'split') that occurs when theadditional_configs_urlssetting is empty or null in the database.Changes
hiddifypanel/panel/user/user.py..split("\n")call with a conditional check to ensure an empty list is passed toget_and_merge_urlsif no URLs are configured.Why this is needed
When a user hasn't configured any additional URLs, the panel currently crashes while trying to render the user page because it expects a string but receives
None.