Skip to content

Fix clippy warnings blocking release build - #17

Draft
halcycon with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-lint-issues
Draft

Fix clippy warnings blocking release build#17
halcycon with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-lint-issues

Conversation

Copilot AI commented Nov 14, 2025

Copy link
Copy Markdown
Contributor

Eliminates all clippy warnings preventing clean release builds. The workspace now compiles with -D warnings.

Changes by category

Unused code removal

  • Removed 16 unused imports across transport, SIP, and ACME modules (auto-fixed)
  • Prefixed 5 unused variables with _ in handlers and B2BUA

Dead code handling

  • Added #[allow(dead_code)] to 4 fields/methods intended for future use (http_port, get_key_authorization, config, server_config)

Trait implementations

  • Implemented Display for SdpSession, removed shadowing to_string() method
  • Implemented FromStr for Method, removed confusing from_str() method

Code style

  • Removed redundant trim() before split_whitespace() in console parser
  • Added #[allow(clippy::too_many_arguments)] to 2 functions where parameter groups are contextually coherent

Example: SdpSession trait implementation

Before:

impl SdpSession {
    pub fn to_string(&self) -> String { /* ... */ }
}
// Clippy: inherent_to_string shadows Display trait

After:

impl std::fmt::Display for SdpSession {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { /* ... */ }
}
// Usage: session.to_string() still works via Display trait
Original prompt

Fix the Lint issues that are preventing the release from building.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: halcycon <8266551+halcycon@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix lint issues preventing release build Nov 14, 2025
Copilot AI requested a review from halcycon November 14, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants