Skip to content

Remove the private API for the hosted explorer #5978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 13, 2025
Merged

Remove the private API for the hosted explorer #5978

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab64dc6
server/index-node: Remove private explorer API
lutter Apr 26, 2025
d444553
graph: Remove explorer-specific env vars
lutter Apr 26, 2025
a383f5e
graph: Remove unneeded methods from StatusStore trait
lutter Apr 26, 2025
2d18674
graph, store: Simplify VersionInfo
lutter Apr 26, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
graph: Remove explorer-specific env vars
  • Loading branch information
@lutter
lutter committed May 13, 2025
commit d44455392d3b81aa1474776d0421455ea680bdd1
18 changes: 0 additions & 18 deletions graph/src/env/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,15 +168,6 @@ pub struct EnvVars {
/// Set by the flag `GRAPH_LOG_TRIGGER_DATA`. Off by
/// default.
pub log_trigger_data: bool,
/// Set by the environment variable `GRAPH_EXPLORER_TTL`
/// (expressed in seconds). The default value is 10s.
pub explorer_ttl: Duration,
/// Set by the environment variable `GRAPH_EXPLORER_LOCK_THRESHOLD`
/// (expressed in milliseconds). The default value is 100ms.
pub explorer_lock_threshold: Duration,
/// Set by the environment variable `GRAPH_EXPLORER_QUERY_THRESHOLD`
/// (expressed in milliseconds). The default value is 500ms.
pub explorer_query_threshold: Duration,
/// Set by the environment variable `EXTERNAL_HTTP_BASE_URL`. No default
/// value is provided.
pub external_http_base_url: Option<String>,
Expand Down Expand Up @@ -313,9 +304,6 @@ impl EnvVars {
postpone_attribute_index_creation: inner.postpone_attribute_index_creation.0
|| cfg!(debug_assertions),
log_trigger_data: inner.log_trigger_data.0,
explorer_ttl: Duration::from_secs(inner.explorer_ttl_in_secs),
explorer_lock_threshold: Duration::from_millis(inner.explorer_lock_threshold_in_msec),
explorer_query_threshold: Duration::from_millis(inner.explorer_query_threshold_in_msec),
external_http_base_url: inner.external_http_base_url,
external_ws_base_url: inner.external_ws_base_url,
static_filters_threshold: inner.static_filters_threshold,
Expand Down Expand Up @@ -476,12 +464,6 @@ struct Inner {
postpone_attribute_index_creation: EnvVarBoolean,
#[envconfig(from = "GRAPH_LOG_TRIGGER_DATA", default = "false")]
log_trigger_data: EnvVarBoolean,
#[envconfig(from = "GRAPH_EXPLORER_TTL", default = "10")]
explorer_ttl_in_secs: u64,
#[envconfig(from = "GRAPH_EXPLORER_LOCK_THRESHOLD", default = "100")]
explorer_lock_threshold_in_msec: u64,
#[envconfig(from = "GRAPH_EXPLORER_QUERY_THRESHOLD", default = "500")]
explorer_query_threshold_in_msec: u64,
#[envconfig(from = "EXTERNAL_HTTP_BASE_URL")]
external_http_base_url: Option<String>,
#[envconfig(from = "EXTERNAL_WS_BASE_URL")]
Expand Down